Update file extensions on configs

Author: nzakas

lib/config-generator.js

@@ -2,6 +2,11 @@
  * @fileoverview to generate config files.
  * @author 唯然<[email protected]>
  */
+
+//-----------------------------------------------------------------------------
+// Imports
+//-----------------------------------------------------------------------------
+
 import process from "node:process";
 import path from "node:path";
 import { spawnSync } from "node:child_process";
@@ -11,6 +16,41 @@ import { isPackageTypeModule, installSyncSaveDev, fetchPeerDependencies, findPac
 import { getShorthandName } from "./utils/naming.js";
 import * as log from "./utils/logging.js";
 
+//-----------------------------------------------------------------------------
+// Helpers
+//-----------------------------------------------------------------------------
+
+/**
+ * Get the file extensions to lint based on the user's answers.
+ * @param {Object} answers The answers provided by the user.
+ * @returns {string[]} The file extensions to lint.
+ */
+function getExtensions(answers) {
+    const extensions = ["js", "mjs", "cjs"];
+
+    if (answers.language === "typescript") {
+        extensions.push("ts");
+    }
+
+    if (answers.framework === "vue") {
+        extensions.push("vue");
+    }
+
+    if (answers.framework === "react") {
+        extensions.push("jsx");
+
+        if (answers.language === "typescript") {
+            extensions.push("tsx");
+        }
+    }
+
+    return extensions;
+}
+
+//-----------------------------------------------------------------------------
+// Exports
+//-----------------------------------------------------------------------------
+
 /**
  * Class representing a ConfigGenerator.
  */
@@ -112,7 +152,7 @@ export class ConfigGenerator {
         this.answers.config = typeof this.answers.config === "string"
             ? { packageName: this.answers.config, type: "flat" }
             : this.answers.config;
-        const extensions = []; // file extensions to lint, the default is ["js", "mjs", "cjs"]
+        const extensions = `**/*.{${getExtensions(this.answers)}}`;
 
         let importContent = "import { defineConfig } from \"eslint/config\";\n";
         const helperContent = `import path from "node:path";
@@ -141,7 +181,7 @@ const compat = new FlatCompat({baseDirectory: __dirname, recommendedConfig: js.c
                 "browser,node": "globals: {...globals.browser, ...globals.node}"
             };
 
-            exportContent += `  { files: ["**/*.js"], languageOptions: { ${envContent[this.answers.env.join(",")]} } },\n`;
+            exportContent += `  { files: ["${extensions}"], languageOptions: { ${envContent[this.answers.env.join(",")]} } },\n`;
         }
 
         if (this.answers.purpose === "syntax") {
@@ -150,35 +190,27 @@ const compat = new FlatCompat({baseDirectory: __dirname, recommendedConfig: js.c
         } else if (this.answers.purpose === "problems") {
             this.result.devDependencies.push("@eslint/js");
             importContent += "import js from \"@eslint/js\";\n";
-            exportContent += "  { files: [\"**/*.js\"], plugins: { js }, extends: [\"js/recommended\"] },\n";
+            exportContent += `  { files: ["${extensions}"], plugins: { js }, extends: ["js/recommended"] },\n`;
         }
 
         if (this.answers.language === "typescript") {
-            extensions.push("ts");
             this.result.devDependencies.push("typescript-eslint");
             importContent += "import tseslint from \"typescript-eslint\";\n";
             exportContent += "  tseslint.configs.recommended,\n";
         }
 
         if (this.answers.framework === "vue") {
-            extensions.push("vue");
             this.result.devDependencies.push("eslint-plugin-vue");
             importContent += "import pluginVue from \"eslint-plugin-vue\";\n";
             exportContent += "  pluginVue.configs[\"flat/essential\"],\n";
 
             // https://eslint.vuejs.org/user-guide/#how-to-use-a-custom-parser
             if (this.answers.language === "typescript") {
-                exportContent += "  {files: [\"**/*.vue\"], languageOptions: { parserOptions: { parser: tseslint.parser } } },\n";
+                exportContent += "  { files: [\"**/*.vue\"], languageOptions: { parserOptions: { parser: tseslint.parser } } },\n";
             }
         }
 
         if (this.answers.framework === "react") {
-            extensions.push("jsx");
-
-            if (this.answers.language === "typescript") {
-                extensions.push("tsx");
-            }
-
             this.result.devDependencies.push("eslint-plugin-react");
             importContent += "import pluginReact from \"eslint-plugin-react\";\n";
             exportContent += "  pluginReact.configs.flat.recommended,\n";
@@ -224,7 +256,7 @@ const compat = new FlatCompat({baseDirectory: __dirname, recommendedConfig: js.c
             this.result.devDependencies.push("@eslint/eslintrc", "@eslint/js");
         }
 
-        const lintFilesConfig = extensions.length > 0 ? `  { files: ["**/*.{${["js", "mjs", "cjs", ...extensions]}}"] },\n` : "";
+        const lintFilesConfig = `  { files: ["${extensions}"] },\n`;
 
         exportContent = `${lintFilesConfig}${exportContent}`;
 

tests/__snapshots__/config@eslint-config-airbnb

@@ -12,6 +12,7 @@ const __dirname = path.dirname(__filename);
 const compat = new FlatCompat({baseDirectory: __dirname, recommendedConfig: js.configs.recommended});
 
 export default defineConfig([
+  { files: ["**/*.{js,mjs,cjs}"] },
   compat.extends("airbnb"),
 ]);",
   "configFilename": "eslint.config.mjs",

tests/__snapshots__/config@eslint-config-airbnb-base

@@ -12,6 +12,7 @@ const __dirname = path.dirname(__filename);
 const compat = new FlatCompat({baseDirectory: __dirname, recommendedConfig: js.configs.recommended});
 
 export default defineConfig([
+  { files: ["**/*.{js,mjs,cjs}"] },
   compat.extends("airbnb-base"),
 ]);",
   "configFilename": "eslint.config.mjs",

tests/__snapshots__/config@eslint-config-standard

@@ -12,6 +12,7 @@ const __dirname = path.dirname(__filename);
 const compat = new FlatCompat({baseDirectory: __dirname, recommendedConfig: js.configs.recommended});
 
 export default defineConfig([
+  { files: ["**/*.{js,mjs,cjs}"] },
   compat.extends("standard"),
 ]);",
   "configFilename": "eslint.config.mjs",

tests/__snapshots__/config@eslint-config-standard-flat

@@ -4,6 +4,7 @@ import config from "eslint-config-standard";
 
 
 export default defineConfig([
+  { files: ["**/*.{js,mjs,cjs}"] },
   config,
 ]);",
   "configFilename": "eslint.config.mjs",

tests/__snapshots__/config@eslint-config-standard-flat2

@@ -4,6 +4,7 @@ import config from "eslint-config-standard";
 
 
 export default defineConfig([
+  { files: ["**/*.{js,mjs,cjs}"] },
   config,
 ]);",
   "configFilename": "eslint.config.mjs",

tests/__snapshots__/config@eslint-config-xo

@@ -4,6 +4,7 @@ import config from "eslint-config-xo";
 
 
 export default defineConfig([
+  { files: ["**/*.{js,mjs,cjs}"] },
   config,
 ]);",
   "configFilename": "eslint.config.mjs",

tests/__snapshots__/empty

@@ -3,7 +3,7 @@
 
 
 export default defineConfig([
-  {}
+  { files: ["**/*.{js,mjs,cjs}"] },
 ]);",
   "configFilename": "eslint.config.js",
   "devDependencies": [

tests/__snapshots__/problems-commonjs-none-javascript

@@ -5,9 +5,10 @@ import js from "@eslint/js";
 
 
 export default defineConfig([
+  { files: ["**/*.{js,mjs,cjs}"] },
   { files: ["**/*.js"], languageOptions: { sourceType: "commonjs" } },
-  { files: ["**/*.js"], languageOptions: { globals: {...globals.browser, ...globals.node} } },
-  { files: ["**/*.js"], plugins: { js }, extends: ["js/recommended"] },
+  { files: ["**/*.{js,mjs,cjs}"], languageOptions: { globals: {...globals.browser, ...globals.node} } },
+  { files: ["**/*.{js,mjs,cjs}"], plugins: { js }, extends: ["js/recommended"] },
 ]);",
   "configFilename": "eslint.config.js",
   "devDependencies": [

tests/__snapshots__/problems-commonjs-none-typescript

@@ -8,8 +8,8 @@ import tseslint from "typescript-eslint";
 export default defineConfig([
   { files: ["**/*.{js,mjs,cjs,ts}"] },
   { files: ["**/*.js"], languageOptions: { sourceType: "commonjs" } },
-  { files: ["**/*.js"], languageOptions: { globals: {...globals.browser, ...globals.node} } },
-  { files: ["**/*.js"], plugins: { js }, extends: ["js/recommended"] },
+  { files: ["**/*.{js,mjs,cjs,ts}"], languageOptions: { globals: {...globals.browser, ...globals.node} } },
+  { files: ["**/*.{js,mjs,cjs,ts}"], plugins: { js }, extends: ["js/recommended"] },
   tseslint.configs.recommended,
 ]);",
   "configFilename": "eslint.config.js",