Skip to content

Commit a29a02e

Browse files
committed
fix: review suggestions
1 parent 234839f commit a29a02e

File tree

4 files changed

+9
-3
lines changed

4 files changed

+9
-3
lines changed

lib/config-generator.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -172,9 +172,6 @@ export class ConfigGenerator {
172172
exportContent += " pluginReact.configs.flat.recommended,\n";
173173
}
174174

175-
if (needCompatHelper) {
176-
this.result.devDependencies.push("@eslint/eslintrc", "@eslint/js");
177-
}
178175
} else {
179176
exportContent += " { ignores: [\"**/*.js\", \"**/*.cjs\", \"**/*.mjs\"] },\n";
180177
}
@@ -278,6 +275,9 @@ export class ConfigGenerator {
278275
}
279276
}
280277

278+
if (needCompatHelper) {
279+
this.result.devDependencies.push("@eslint/eslintrc", "@eslint/js");
280+
}
281281
this.result.configContent = `${importContent}
282282
${needCompatHelper ? helperContent : ""}
283283
export default defineConfig([\n${exportContent || " {}\n"}]);`; // defaults to `[{}]` to avoid empty config warning

tests/__snapshots__/config@eslint-config-airbnb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ export default defineConfig([
2222
"eslint-plugin-import@^2.25.3",
2323
"eslint-plugin-jsx-a11y@^6.5.1",
2424
"eslint-plugin-react-hooks@^4.3.0",
25+
"@eslint/eslintrc",
26+
"@eslint/js",
2527
],
2628
"installFlags": [
2729
"-D",

tests/__snapshots__/config@eslint-config-airbnb-base

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ export default defineConfig([
1919
"eslint@^7.32.0 || ^8.2.0",
2020
"eslint-config-airbnb-base",
2121
"eslint-plugin-import@^2.25.2",
22+
"@eslint/eslintrc",
23+
"@eslint/js",
2224
],
2325
"installFlags": [
2426
"-D",

tests/__snapshots__/config@eslint-config-standard

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ export default defineConfig([
2121
"eslint-plugin-import@^2.25.2",
2222
"eslint-plugin-n@^15.0.0 || ^16.0.0 ",
2323
"eslint-plugin-promise@^6.0.0",
24+
"@eslint/eslintrc",
25+
"@eslint/js",
2426
],
2527
"installFlags": [
2628
"-D",

0 commit comments

Comments
 (0)