Skip to content

Conversation

@pdobacz
Copy link
Contributor

@pdobacz pdobacz commented Nov 5, 2025

🗒️ Description

Opening as draft, as I am not sure this makes sense (also CI fails for a mysterious reason and I should port from this test. EDIT: done, marked ready for review

The goal is to have specifically a state test, where not only tx type being not supported is tested, but additionally that no unexpected changes got through to the state, this comes up as uncovered in evmone.

So my question is: do we want a test like this? If yes I'll fix the issues and also add the same thing for other missed types.

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

@pdobacz pdobacz force-pushed the tests/tx-types branch 2 times, most recently from 79ad559 to ed3503d Compare November 6, 2025 10:00
@pdobacz pdobacz marked this pull request as ready for review November 6, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants