lints

Signed-off-by: Ignacio Hagopian <[email protected]>

Author: jsign

tree.go

@@ -954,7 +954,7 @@ func (n *LeafNode) getOldCn(index byte) (*Point, *Fr) {
 	return c, &oldc
 }
 
-func (n *LeafNode) updateC(stem []byte, index byte, c *Point, oldc *Fr) {
+func (n *LeafNode) updateC(index byte, c *Point, oldc *Fr) {
 	var (
 		newc Fr
 		poly [256]Fr
@@ -963,13 +963,6 @@ func (n *LeafNode) updateC(stem []byte, index byte, c *Point, oldc *Fr) {
 	toFr(&newc, c)
 	newc.Sub(&newc, oldc)
 	poly[2+(index/128)] = newc
-
-	if n.commitment == nil {
-		poly[0].SetUint64(1)
-		StemFromBytes(&poly[1], stem)
-		n.commitment = cfg.CommitToPoly(poly[:], 0)
-		return
-	}
 	n.commitment.Add(n.commitment, cfg.CommitToPoly(poly[:], 0))
 }
 
@@ -1026,22 +1019,6 @@ func (n *LeafNode) updateLeaf(index byte, value []byte) {
 	n.values[index] = value
 }
 
-/*
-func (n *LeafNode) updateLeaf(index byte, value []byte) {
-	if n.commitment == nil {
-		panic("nil commitment")
-	}
-
-	c, oldc := n.getOldCn(index)
-
-	n.updateCn(index, value, c)
-
-	n.updateC(index, c, oldc)
-
-	n.values[index] = value
-}
-*/
-
 func (n *LeafNode) updateMultipleLeaves(values [][]byte) {
 	for i := range values {
 		if values[i] != nil {
@@ -1050,41 +1027,6 @@ func (n *LeafNode) updateMultipleLeaves(values [][]byte) {
 	}
 }
 
-/*
-func (n *LeafNode) updateMultipleLeaves(values [][]byte) {
-	if n.commitment == nil {
-		panic("nil commitment")
-	}
-
-	var c1, c2 *Point
-	var old1, old2 *Fr
-	for i, v := range values {
-		if len(v) != 0 && !bytes.Equal(v, n.values[i]) {
-			if i < 128 {
-				if c1 == nil {
-					c1, old1 = n.getOldCn(byte(i))
-				}
-				n.updateCn(byte(i), v, c1)
-			} else {
-				if c2 == nil {
-					c2, old2 = n.getOldCn(byte(i))
-				}
-				n.updateCn(byte(i), v, c2)
-			}
-
-			n.values[i] = v
-		}
-	}
-
-	if c1 != nil {
-		n.updateC(0, c1, old1)
-	}
-	if c2 != nil {
-		n.updateC(128, c2, old2)
-	}
-}
-*/
-
 func (n *LeafNode) InsertOrdered(key []byte, value []byte, _ NodeFlushFn) error {
 	// In the previous version, this value used to be flushed on insert.
 	// This is no longer the case, as all values at the last level get
@@ -1154,14 +1096,14 @@ func (leaf *LeafNode) Commit() *Point {
 			frPool.Put(c1polyp)
 		}()
 
-		count = fillSuffixTreePoly(c1poly[:], leaf.values[:128])
-		leaf.c1 = cfg.CommitToPoly(c1poly[:], 256-count)
+		count = fillSuffixTreePoly(c1poly, leaf.values[:128])
+		leaf.c1 = cfg.CommitToPoly(c1poly, 256-count)
 
 		for i := 0; i < 256; i++ {
 			c1poly[i] = Fr{}
 		}
-		count = fillSuffixTreePoly(c1poly[:], leaf.values[128:])
-		leaf.c2 = cfg.CommitToPoly(c1poly[:], 256-count)
+		count = fillSuffixTreePoly(c1poly, leaf.values[128:])
+		leaf.c2 = cfg.CommitToPoly(c1poly, 256-count)
 
 		for i := 0; i < 256; i++ {
 			c1poly[i] = Fr{}
@@ -1170,7 +1112,7 @@ func (leaf *LeafNode) Commit() *Point {
 		StemFromBytes(&c1poly[1], leaf.stem)
 
 		toFrMultiple([]*Fr{&c1poly[2], &c1poly[3]}, []*Point{leaf.c1, leaf.c2})
-		leaf.commitment = cfg.CommitToPoly(c1poly[:], 252)
+		leaf.commitment = cfg.CommitToPoly(c1poly, 252)
 
 	} else if len(leaf.cow) != 0 {
 		// If we've already have a calculated commitment, and there're touched leaf values, we do a diff update.
@@ -1180,23 +1122,23 @@ func (leaf *LeafNode) Commit() *Point {
 			if !bytes.Equal(oldValue, leaf.values[i]) {
 				if i < 128 {
 					if c1 == nil {
-						c1, old1 = leaf.getOldCn(byte(i))
+						c1, old1 = leaf.getOldCn(i)
 					}
-					leaf.updateCn(byte(i), oldValue, c1)
+					leaf.updateCn(i, oldValue, c1)
 				} else {
 					if c2 == nil {
-						c2, old2 = leaf.getOldCn(byte(i))
+						c2, old2 = leaf.getOldCn(i)
 					}
-					leaf.updateCn(byte(i), oldValue, c2)
+					leaf.updateCn(i, oldValue, c2)
 				}
 			}
 		}
 
 		if c1 != nil {
-			leaf.updateC(leaf.stem, 0, c1, old1)
+			leaf.updateC(0, c1, old1)
 		}
 		if c2 != nil {
-			leaf.updateC(leaf.stem, 128, c2, old2)
+			leaf.updateC(128, c2, old2)
 		}
 		leaf.cow = nil
 	}