feat: migrate unit tests to use Shouldly assertions and clean up global usings

Author: kamilbaczek

Chapter-4-applying-tactical-domain-driven-design/Fitnet.Common/Fitnet.Common.Api.UnitTests/GlobalUsings.cs

@@ -1,6 +1 @@
-global using System.Net;
-global using Xunit;
-global using FluentAssertions;
-global using Microsoft.AspNetCore.Http;
-global using Newtonsoft.Json;
-global using Shouldly;
+global using Shouldly;

Chapter-4-applying-tactical-domain-driven-design/Fitnet.Common/Fitnet.Common.Core.UnitTests/GlobalUsings.cs

@@ -1,3 +1,2 @@
 global using Xunit;
-global using FluentAssertions;
 global using Shouldly;

Chapter-4-applying-tactical-domain-driven-design/Fitnet.Common/Fitnet.Common.Core.UnitTests/ValueObjectTests.cs

@@ -1,5 +1,9 @@
 namespace EvolutionaryArchitecture.Fitnet.Common.Core.UnitTests;
 
+using System;
+using System.Collections.Generic;
+using System.Linq;
+
 public class ValueObjectTests
 {
     private const int DefaultIntProperty = 1;
@@ -13,10 +17,10 @@ internal void Given_two_same_type_objects_When_values_are_the_same_Then_should_b
         var secondObject = new FakeValueObject();
 
         // Act & Assert
-        firstObject.Should().Be(secondObject);
-        firstObject.Equals(secondObject).Should().BeTrue();
-        (firstObject == secondObject).Should().BeTrue();
-        (firstObject != secondObject).Should().BeFalse();
+        firstObject.ShouldBe(secondObject);
+        firstObject.Equals(secondObject).ShouldBeTrue();
+        (firstObject == secondObject).ShouldBeTrue();
+        (firstObject != secondObject).ShouldBeFalse();
     }
 
     [Fact]
@@ -28,14 +32,14 @@ internal void Given_two_same_type_objects_When_values_are_not_the_same_Then_shou
         var thirdObject = new FakeValueObject(property2: Guid.NewGuid().ToString());
 
         // Act & Assert
-        firstObject.Should().NotBe(secondObject);
-        firstObject.Equals(secondObject).Should().BeFalse();
-        (firstObject == secondObject).Should().BeFalse();
-        (firstObject != secondObject).Should().BeTrue();
-        firstObject.Should().NotBe(thirdObject);
-        firstObject.Equals(thirdObject).Should().BeFalse();
-        (firstObject == thirdObject).Should().BeFalse();
-        (firstObject != thirdObject).Should().BeTrue();
+        firstObject.ShouldNotBe(secondObject);
+        firstObject.Equals(secondObject).ShouldBeFalse();
+        (firstObject == secondObject).ShouldBeFalse();
+        (firstObject != secondObject).ShouldBeTrue();
+        firstObject.ShouldNotBe(thirdObject);
+        firstObject.Equals(thirdObject).ShouldBeFalse();
+        (firstObject == thirdObject).ShouldBeFalse();
+        (firstObject != thirdObject).ShouldBeTrue();
     }
 
     [Fact]
@@ -46,7 +50,7 @@ internal void Given_two_same_type_objects_When_values_are_the_same_Then_should_h
         var secondObject = new FakeValueObject();
 
         // Act & Assert
-        firstObject.GetHashCode().Should().Be(secondObject.GetHashCode());
+        firstObject.GetHashCode().ShouldBe(secondObject.GetHashCode());
     }
 
     [Fact]
@@ -57,10 +61,10 @@ internal void Given_two_different_type_objects_When_values_are_the_same_Then_sho
         var secondObject = new AnotherTypeFakeValueObject();
 
         // Act & Assert
-        firstObject.Should().NotBe(secondObject);
-        firstObject.Equals(secondObject).Should().BeFalse();
-        (firstObject == secondObject).Should().BeFalse();
-        (firstObject != secondObject).Should().BeTrue();
+        // firstObject.ShouldNotBe(secondObject);
+        firstObject.Equals(secondObject).ShouldBeFalse();
+        (firstObject == secondObject).ShouldBeFalse();
+        (firstObject != secondObject).ShouldBeTrue();
     }
 
     [Fact]
@@ -80,8 +84,8 @@ internal void Given_multiple_objects_When_looking_for_specific_one_Then_should_r
         var result = valueObjects.Where(vo => vo == targetValueObject).ToList();
 
         // Assert
-        result.Should().HaveCount(2);
-        result.Should().AllBeEquivalentTo(targetValueObject);
+        result.Count.ShouldBe(2);
+        result.ForEach(vo => vo.ShouldBe(targetValueObject));
     }
 
     [Fact]
@@ -101,7 +105,7 @@ internal void Given_multiple_objects_When_looking_for_non_existing_one_Then_shou
         var result = valueObjects.Where(vo => vo == targetValueObject).ToList();
 
         // Assert
-        result.Should().BeEmpty();
+        result.ShouldBeEmpty();
     }
 
     private class FakeValueObject(int property1 = DefaultIntProperty, string property2 = DefaultStringProperty) : ValueObject

Chapter-4-applying-tactical-domain-driven-design/Fitnet.Common/Fitnet.Common.IntegrationTestsToolbox/GlobalUsings.cs

@@ -1,6 +1,5 @@
 global using System.Reflection;
 global using JetBrains.Annotations;
-global using Xunit;
 global using Microsoft.AspNetCore.Mvc.Testing;
 global using Microsoft.AspNetCore.Hosting;
 global using Microsoft.Extensions.Configuration;