feat: migrate from FluentAssertions to Shouldly in unit and integration tests

Author: kamilbaczek

Chapter-4-applying-tactical-domain-driven-design/Fitnet.Common/Fitnet.Common.Api.UnitTests/ExceptionMiddlewareTests.cs

@@ -1,6 +1,14 @@
 namespace EvolutionaryArchitecture.Fitnet.Common.Api.UnitTests;
 
+using System;
+using System.IO;
+using System.Net;
+using System.Threading.Tasks;
 using ErrorHandling;
+using Microsoft.AspNetCore.Http;
+using Newtonsoft.Json;
+using Shouldly;
+using Xunit;
 
 public sealed class ExceptionMiddlewareTests
 {
@@ -18,10 +26,10 @@ internal async Task Given_any_unexpected_exception_Then_returns_internal_server_
         await middleware.InvokeAsync(_context);
 
         // Assert
-        _context.Response.StatusCode.Should().Be((int)HttpStatusCode.InternalServerError);
+        _context.Response.StatusCode.ShouldBe((int)HttpStatusCode.InternalServerError);
 
         var responseMessage = await GetExceptionResponseMessage();
-        responseMessage.Should().Be(exceptionMessage);
+        responseMessage.ShouldBe(exceptionMessage);
     }
 
     private static DefaultHttpContext GetHttpContext() =>

Chapter-4-applying-tactical-domain-driven-design/Fitnet.Common/Fitnet.Common.Api.UnitTests/Fitnet.Common.Api.UnitTests.csproj

@@ -11,6 +11,7 @@
     <ItemGroup>
         <PackageReference Include="FluentAssertions" Version="6.12.2" />
         <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
+        <PackageReference Include="Shouldly" Version="4.3.0" />
         <PackageReference Include="xunit" Version="2.9.2" />
         <PackageReference Include="xunit.runner.visualstudio" Version="2.8.2">
           <PrivateAssets>all</PrivateAssets>

Chapter-4-applying-tactical-domain-driven-design/Fitnet.Common/Fitnet.Common.Core.UnitTests/BusinessRulesEngine/BusinessRuleValidatorTests.cs

@@ -1,7 +1,6 @@
 namespace EvolutionaryArchitecture.Fitnet.Common.Core.UnitTests.BusinessRulesEngine;
 
 using BussinessRules;
-using EvolutionaryArchitecture.Fitnet.Common.UnitTesting.Assertions.ErrorOr;
 
 public sealed class BusinessRuleValidatorTests
 {
@@ -14,7 +13,7 @@ internal void Given_concrete_business_rule_which_is_met_Then_validation_should_p
         var result = BusinessRuleValidator.Validate(new FakeBusinessRule(20));
 
         // Assert
-        result.Should().BeSuccessful();
+        result.IsError.ShouldBeFalse();
     }
 
     [Fact]
@@ -27,6 +26,6 @@ internal void Given_concrete_business_rule_which_is_not_met_Then_validation_shou
         var result = BusinessRuleValidator.Validate(testRule);
 
         // Assert
-        result.Should().ContainError(testRule.Error);
+        result.Errors.ShouldContain(testRule.Error);
     }
 }

Chapter-4-applying-tactical-domain-driven-design/Fitnet.Common/Fitnet.Common.Core.UnitTests/Fitnet.Common.Core.UnitTests.csproj

@@ -10,7 +10,7 @@
     </ItemGroup>
 
     <ItemGroup>
-      <PackageReference Include="FluentAssertions" Version="6.12.2" />
+      <PackageReference Include="Shouldly" Version="4.3.0" />
       <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
       <PackageReference Include="xunit" Version="2.9.2" />
       <PackageReference Include="xunit.runner.visualstudio" Version="2.8.2">

Chapter-4-applying-tactical-domain-driven-design/Fitnet.Common/Fitnet.Common.Core.UnitTests/GlobalUsings.cs

@@ -1,2 +1,3 @@
 global using Xunit;
 global using FluentAssertions;
+global using Shouldly;

Chapter-4-applying-tactical-domain-driven-design/Fitnet/Src/Offers/Tests/Fitnet.Offers.IntegrationTests/Fitnet.Offers.IntegrationTests.csproj

@@ -8,6 +8,7 @@
         <PackageReference Include="BouncyCastle.Cryptography" Version="2.5.0" />
         <PackageReference Include="evolutionaryarchitecture.fitnet.common.integrationteststoolbox" Version="4.1.7" />
         <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
+        <PackageReference Include="Shouldly" Version="4.3.0" />
         <PackageReference Include="System.Net.Http" Version="4.3.4" />
         <PackageReference Include="System.Text.Encodings.Web" Version="9.0.0" />
         <PackageReference Include="System.Text.Json" Version="9.0.0" />

Chapter-4-applying-tactical-domain-driven-design/Fitnet/Src/Offers/Tests/Fitnet.Offers.IntegrationTests/Prepare/PrepareOfferTests.cs

@@ -6,6 +6,7 @@ namespace EvolutionaryArchitecture.Fitnet.Offers.IntegrationTests.Prepare;
 using Common.IntegrationTestsToolbox.TestEngine.Configuration;
 using EvolutionaryArchitecture.Fitnet.Common.IntegrationTestsToolbox.TestEngine.Database;
 using Passes.IntegrationEvents;
+using Shouldly;
 
 public sealed class PrepareOfferTests : IClassFixture<FitnetWebApplicationFactory<Program>>,
     IClassFixture<DatabaseContainer>
@@ -40,6 +41,6 @@ internal async Task Given_pass_expired_event_published_Then_new_offer_should_be_
     private async Task EnsureThatOfferPreparedEventWasPublished()
     {
         var offerPrepared = await _testEventBus.Published.Any<OfferPrepareEvent>();
-        offerPrepared.Should().BeTrue();
+        offerPrepared.ShouldBeTrue();
     }
 }

Chapter-4-applying-tactical-domain-driven-design/Fitnet/Src/Passes/Tests/Fitnet.Passes.IntegrationTests/Fitnet.Passes.IntegrationTests.csproj

@@ -7,6 +7,7 @@
     <ItemGroup>
         <PackageReference Include="EvolutionaryArchitecture.Fitnet.Common.IntegrationTestsToolbox" Version="4.1.7" />
         <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
+        <PackageReference Include="Shouldly" Version="4.3.0" />
         <PackageReference Include="System.Net.Http" Version="4.3.4" />
         <PackageReference Include="System.Text.Encodings.Web" Version="9.0.0" />
         <PackageReference Include="System.Text.Json" Version="9.0.0" />

Chapter-4-applying-tactical-domain-driven-design/Fitnet/Src/Passes/Tests/Fitnet.Passes.IntegrationTests/GlobalUsings.cs

@@ -3,4 +3,5 @@
 global using Xunit;
 global using Bogus;
 global using FluentAssertions;
-global using MassTransit.Testing;
+global using MassTransit.Testing;
+global using Shouldly;

Chapter-4-applying-tactical-domain-driven-design/Fitnet/Src/Passes/Tests/Fitnet.Passes.IntegrationTests/MarkPassAsExpired/MarkPassAsExpiredTests.cs

@@ -10,6 +10,8 @@ namespace EvolutionaryArchitecture.Fitnet.Passes.IntegrationTests.MarkPassAsExpi
 using Contracts.IntegrationEvents;
 using IntegrationEvents;
 using RegisterPass;
+using System.Net;
+using System.Net.Http.Json;
 
 public sealed class MarkPassAsExpiredTests : IClassFixture<FitnetWebApplicationFactory<Program>>, IClassFixture<DatabaseContainer>
 {
@@ -37,10 +39,10 @@ internal async Task Given_valid_mark_pass_as_expired_request_Then_should_return_
         var url = BuildUrl(registeredPassId);
 
         // Act
-        await _applicationHttpClient.PatchAsJsonAsync(url, EmptyContent);
+        var markAsExpiredResponse = await _applicationHttpClient.PatchAsJsonAsync(url, EmptyContent);
 
         // Assert
-        await EnsureThatPassExpiredEventWasPublished();
+        markAsExpiredResponse.StatusCode.ShouldBe(HttpStatusCode.NoContent);
     }
 
     [Fact]
@@ -52,10 +54,10 @@ internal async Task Given_valid_mark_pass_as_expired_request_Then_should_publish
         var url = BuildUrl(registeredPassId);
 
         // Act
-        var markAsExpiredResponse = await _applicationHttpClient.PatchAsJsonAsync(url, EmptyContent);
+        await _applicationHttpClient.PatchAsJsonAsync(url, EmptyContent);
 
         // Assert
-        markAsExpiredResponse.Should().HaveStatusCode(HttpStatusCode.NoContent);
+        await EnsureThatPassExpiredEventWasPublished();
     }
 
     [Fact]
@@ -69,7 +71,7 @@ internal async Task Given_mark_pass_as_expired_request_with_not_existing_id_Then
         var markAsExpiredResponse = await _applicationHttpClient.PatchAsJsonAsync(url, EmptyContent);
 
         // Assert
-        markAsExpiredResponse.Should().HaveStatusCode(HttpStatusCode.NotFound);
+        markAsExpiredResponse.StatusCode.ShouldBe(HttpStatusCode.NotFound);
     }
 
     private async Task<ContractSignedEvent> RegisterPass()
@@ -86,16 +88,16 @@ private async Task<Guid> GetCreatedPass(Guid customerId)
         var getAllPassesResponse = await _applicationHttpClient.GetAsync(PassesApiPaths.GetAll);
         var response = await getAllPassesResponse.Content.ReadFromJsonAsync<GetAllPassesResponse>();
         var createdPass = response!.Passes.FirstOrDefault(pass => pass.CustomerId == customerId);
-        createdPass.Should().NotBeNull();
+        createdPass.ShouldNotBeNull();
 
-        return createdPass!.Id;
+        return createdPass.Id;
     }
 
     private static string BuildUrl(Guid id) => PassesApiPaths.MarkPassAsExpired.Replace("{id}", id.ToString());
 
     private async Task EnsureThatPassExpiredEventWasPublished()
     {
         var passRegisteredEventPublished = await _testEventBus.Published.Any<PassExpiredEvent>();
-        passRegisteredEventPublished.Should().BeTrue();
+        passRegisteredEventPublished.ShouldBeTrue();
     }
 }