Skip to content

Commit b70dbb6

Browse files
ewdlopewdlop
committed
Refactor UI with custom controls for better structure
Replaced existing UI elements in `CharacterCreationDialog.cs` and `Form1.cs` with custom controls, including `CharacterStatsDisplayControl`, `CharacterStatsControl`, `ProgressDisplayControl`, and `QuickActionsControl`. This enhances the organization and maintainability of the code. New controls improve the presentation of character stats, health, experience, and quick actions. Resource files `CharacterStatsControl.resx` and `InventoryForm.resx` were added for localization support. Overall, these changes streamline the UI and improve code readability.
1 parent 09febce commit b70dbb6

File tree

8 files changed

+809
-315
lines changed

8 files changed

+809
-315
lines changed

‎src/Controls/CharacterStatsControl.cs‎

Lines changed: 147 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,147 @@
1+
using System;
2+
using System.Drawing;
3+
using System.Windows.Forms;
4+
5+
namespace WinFormsApp1.Controls
6+
{
7+
public partial class CharacterStatsControl : UserControl
8+
{
9+
private TableLayoutPanel statsLayout;
10+
private Label levelValueLabel;
11+
private Label goldValueLabel;
12+
private Label attackValueLabel;
13+
private Label defenseValueLabel;
14+
private Label expValueLabel;
15+
private Label classValueLabel;
16+
private Label weaponValueLabel;
17+
private Label armorValueLabel;
18+
19+
public CharacterStatsControl()
20+
{
21+
InitializeComponent();
22+
}
23+
24+
private void InitializeComponent()
25+
{
26+
this.Size = new Size(300, 250);
27+
this.BackColor = Color.Transparent;
28+
29+
// Create scrollable panel for stats
30+
Panel scrollablePanel = new Panel
31+
{
32+
Dock = DockStyle.Fill,
33+
AutoScroll = true,
34+
BorderStyle = BorderStyle.None
35+
};
36+
37+
// Create stats layout
38+
statsLayout = new TableLayoutPanel
39+
{
40+
AutoSize = true,
41+
AutoSizeMode = AutoSizeMode.GrowAndShrink,
42+
ColumnCount = 2,
43+
RowCount = 8,
44+
Location = new Point(0, 0),
45+
Padding = new Padding(5)
46+
};
47+
48+
// Set column styles
49+
statsLayout.ColumnStyles.Add(new ColumnStyle(SizeType.AutoSize));
50+
statsLayout.ColumnStyles.Add(new ColumnStyle(SizeType.AutoSize));
51+
52+
CreateStatLabels();
53+
AddLabelsToLayout();
54+
55+
scrollablePanel.Controls.Add(statsLayout);
56+
this.Controls.Add(scrollablePanel);
57+
}
58+
59+
private void CreateStatLabels()
60+
{
61+
// Level
62+
var levelLabel = new Label { Text = "Level:", AutoSize = true, Margin = new Padding(2) };
63+
levelValueLabel = new Label { Text = "1", AutoSize = true, Font = new Font("Arial", 8, FontStyle.Bold), Margin = new Padding(2) };
64+
65+
// Gold
66+
var goldLabel = new Label { Text = "Gold:", AutoSize = true, Margin = new Padding(2) };
67+
goldValueLabel = new Label { Text = "50", AutoSize = true, Font = new Font("Arial", 8, FontStyle.Bold), ForeColor = Color.Goldenrod, Margin = new Padding(2) };
68+
69+
// Attack
70+
var attackLabel = new Label { Text = "Attack:", AutoSize = true, Margin = new Padding(2) };
71+
attackValueLabel = new Label { Text = "15", AutoSize = true, Font = new Font("Arial", 8, FontStyle.Bold), ForeColor = Color.Red, Margin = new Padding(2) };
72+
73+
// Defense
74+
var defenseLabel = new Label { Text = "Defense:", AutoSize = true, Margin = new Padding(2) };
75+
defenseValueLabel = new Label { Text = "8", AutoSize = true, Font = new Font("Arial", 8, FontStyle.Bold), ForeColor = Color.Blue, Margin = new Padding(2) };
76+
77+
// Experience
78+
var expLabel = new Label { Text = "Exp:", AutoSize = true, Margin = new Padding(2) };
79+
expValueLabel = new Label { Text = "0", AutoSize = true, Font = new Font("Arial", 8, FontStyle.Bold), ForeColor = Color.Purple, Margin = new Padding(2) };
80+
81+
// Class
82+
var classLabel = new Label { Text = "Class:", AutoSize = true, Margin = new Padding(2) };
83+
classValueLabel = new Label { Text = "Warrior", AutoSize = true, Font = new Font("Arial", 8, FontStyle.Bold), ForeColor = Color.DarkGreen, Margin = new Padding(2) };
84+
85+
// Weapon
86+
var weaponLabel = new Label { Text = "Weapon:", AutoSize = true, Margin = new Padding(2) };
87+
weaponValueLabel = new Label { Text = "None", AutoSize = true, Font = new Font("Arial", 8, FontStyle.Bold), ForeColor = Color.DarkOrange, Margin = new Padding(2) };
88+
89+
// Armor
90+
var armorLabel = new Label { Text = "Armor:", AutoSize = true, Margin = new Padding(2) };
91+
armorValueLabel = new Label { Text = "None", AutoSize = true, Font = new Font("Arial", 8, FontStyle.Bold), ForeColor = Color.DarkCyan, Margin = new Padding(2) };
92+
}
93+
94+
private void AddLabelsToLayout()
95+
{
96+
statsLayout.Controls.Add(new Label { Text = "Level:", AutoSize = true, Margin = new Padding(2) }, 0, 0);
97+
statsLayout.Controls.Add(levelValueLabel, 1, 0);
98+
99+
statsLayout.Controls.Add(new Label { Text = "Gold:", AutoSize = true, Margin = new Padding(2) }, 0, 1);
100+
statsLayout.Controls.Add(goldValueLabel, 1, 1);
101+
102+
statsLayout.Controls.Add(new Label { Text = "Attack:", AutoSize = true, Margin = new Padding(2) }, 0, 2);
103+
statsLayout.Controls.Add(attackValueLabel, 1, 2);
104+
105+
statsLayout.Controls.Add(new Label { Text = "Defense:", AutoSize = true, Margin = new Padding(2) }, 0, 3);
106+
statsLayout.Controls.Add(defenseValueLabel, 1, 3);
107+
108+
statsLayout.Controls.Add(new Label { Text = "Exp:", AutoSize = true, Margin = new Padding(2) }, 0, 4);
109+
statsLayout.Controls.Add(expValueLabel, 1, 4);
110+
111+
statsLayout.Controls.Add(new Label { Text = "Class:", AutoSize = true, Margin = new Padding(2) }, 0, 5);
112+
statsLayout.Controls.Add(classValueLabel, 1, 5);
113+
114+
statsLayout.Controls.Add(new Label { Text = "Weapon:", AutoSize = true, Margin = new Padding(2) }, 0, 6);
115+
statsLayout.Controls.Add(weaponValueLabel, 1, 6);
116+
117+
statsLayout.Controls.Add(new Label { Text = "Armor:", AutoSize = true, Margin = new Padding(2) }, 0, 7);
118+
statsLayout.Controls.Add(armorValueLabel, 1, 7);
119+
}
120+
121+
public void UpdateStats(Player player)
122+
{
123+
if (player == null) return;
124+
125+
levelValueLabel.Text = player.Level.ToString();
126+
goldValueLabel.Text = player.Gold.ToString();
127+
attackValueLabel.Text = player.GetTotalAttack().ToString();
128+
defenseValueLabel.Text = player.GetTotalDefense().ToString();
129+
expValueLabel.Text = $"{player.Experience}/{player.ExperienceToNextLevel}";
130+
classValueLabel.Text = player.CharacterClass.ToString();
131+
weaponValueLabel.Text = player.EquippedWeapon?.Name ?? "None";
132+
armorValueLabel.Text = player.EquippedArmor?.Name ?? "None";
133+
}
134+
135+
public void ClearStats()
136+
{
137+
levelValueLabel.Text = "-";
138+
goldValueLabel.Text = "-";
139+
attackValueLabel.Text = "-";
140+
defenseValueLabel.Text = "-";
141+
expValueLabel.Text = "-";
142+
classValueLabel.Text = "-";
143+
weaponValueLabel.Text = "None";
144+
armorValueLabel.Text = "None";
145+
}
146+
}
147+
}

‎src/Controls/CharacterStatsControl.resx‎

Lines changed: 120 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,120 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<root>
3+
<!--
4+
Microsoft ResX Schema
5+
6+
Version 2.0
7+
8+
The primary goals of this format is to allow a simple XML format
9+
that is mostly human readable. The generation and parsing of the
10+
various data types are done through the TypeConverter classes
11+
associated with the data types.
12+
13+
Example:
14+
15+
... ado.net/XML headers & schema ...
16+
<resheader name="resmimetype">text/microsoft-resx</resheader>
17+
<resheader name="version">2.0</resheader>
18+
<resheader name="reader">System.Resources.ResXResourceReader, System.Windows.Forms, ...</resheader>
19+
<resheader name="writer">System.Resources.ResXResourceWriter, System.Windows.Forms, ...</resheader>
20+
<data name="Name1"><value>this is my long string</value><comment>this is a comment</comment></data>
21+
<data name="Color1" type="System.Drawing.Color, System.Drawing">Blue</data>
22+
<data name="Bitmap1" mimetype="application/x-microsoft.net.object.binary.base64">
23+
<value>[base64 mime encoded serialized .NET Framework object]</value>
24+
</data>
25+
<data name="Icon1" type="System.Drawing.Icon, System.Drawing" mimetype="application/x-microsoft.net.object.bytearray.base64">
26+
<value>[base64 mime encoded string representing a byte array form of the .NET Framework object]</value>
27+
<comment>This is a comment</comment>
28+
</data>
29+
30+
There are any number of "resheader" rows that contain simple
31+
name/value pairs.
32+
33+
Each data row contains a name, and value. The row also contains a
34+
type or mimetype. Type corresponds to a .NET class that support
35+
text/value conversion through the TypeConverter architecture.
36+
Classes that don't support this are serialized and stored with the
37+
mimetype set.
38+
39+
The mimetype is used for serialized objects, and tells the
40+
ResXResourceReader how to depersist the object. This is currently not
41+
extensible. For a given mimetype the value must be set accordingly:
42+
43+
Note - application/x-microsoft.net.object.binary.base64 is the format
44+
that the ResXResourceWriter will generate, however the reader can
45+
read any of the formats listed below.
46+
47+
mimetype: application/x-microsoft.net.object.binary.base64
48+
value : The object must be serialized with
49+
: System.Runtime.Serialization.Formatters.Binary.BinaryFormatter
50+
: and then encoded with base64 encoding.
51+
52+
mimetype: application/x-microsoft.net.object.soap.base64
53+
value : The object must be serialized with
54+
: System.Runtime.Serialization.Formatters.Soap.SoapFormatter
55+
: and then encoded with base64 encoding.
56+
57+
mimetype: application/x-microsoft.net.object.bytearray.base64
58+
value : The object must be serialized into a byte array
59+
: using a System.ComponentModel.TypeConverter
60+
: and then encoded with base64 encoding.
61+
-->
62+
<xsd:schema id="root" xmlns="" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:msdata="urn:schemas-microsoft-com:xml-msdata">
63+
<xsd:import namespace="http://www.w3.org/XML/1998/namespace" />
64+
<xsd:element name="root" msdata:IsDataSet="true">
65+
<xsd:complexType>
66+
<xsd:choice maxOccurs="unbounded">
67+
<xsd:element name="metadata">
68+
<xsd:complexType>
69+
<xsd:sequence>
70+
<xsd:element name="value" type="xsd:string" minOccurs="0" />
71+
</xsd:sequence>
72+
<xsd:attribute name="name" use="required" type="xsd:string" />
73+
<xsd:attribute name="type" type="xsd:string" />
74+
<xsd:attribute name="mimetype" type="xsd:string" />
75+
<xsd:attribute ref="xml:space" />
76+
</xsd:complexType>
77+
</xsd:element>
78+
<xsd:element name="assembly">
79+
<xsd:complexType>
80+
<xsd:attribute name="alias" type="xsd:string" />
81+
<xsd:attribute name="name" type="xsd:string" />
82+
</xsd:complexType>
83+
</xsd:element>
84+
<xsd:element name="data">
85+
<xsd:complexType>
86+
<xsd:sequence>
87+
<xsd:element name="value" type="xsd:string" minOccurs="0" msdata:Ordinal="1" />
88+
<xsd:element name="comment" type="xsd:string" minOccurs="0" msdata:Ordinal="2" />
89+
</xsd:sequence>
90+
<xsd:attribute name="name" type="xsd:string" use="required" msdata:Ordinal="1" />
91+
<xsd:attribute name="type" type="xsd:string" msdata:Ordinal="3" />
92+
<xsd:attribute name="mimetype" type="xsd:string" msdata:Ordinal="4" />
93+
<xsd:attribute ref="xml:space" />
94+
</xsd:complexType>
95+
</xsd:element>
96+
<xsd:element name="resheader">
97+
<xsd:complexType>
98+
<xsd:sequence>
99+
<xsd:element name="value" type="xsd:string" minOccurs="0" msdata:Ordinal="1" />
100+
</xsd:sequence>
101+
<xsd:attribute name="name" type="xsd:string" use="required" />
102+
</xsd:complexType>
103+
</xsd:element>
104+
</xsd:choice>
105+
</xsd:complexType>
106+
</xsd:element>
107+
</xsd:schema>
108+
<resheader name="resmimetype">
109+
<value>text/microsoft-resx</value>
110+
</resheader>
111+
<resheader name="version">
112+
<value>2.0</value>
113+
</resheader>
114+
<resheader name="reader">
115+
<value>System.Resources.ResXResourceReader, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
116+
</resheader>
117+
<resheader name="writer">
118+
<value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
119+
</resheader>
120+
</root>

‎src/Controls/CharacterStatsDisplayControl.cs‎

Lines changed: 73 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,73 @@
1+
using System;
2+
using System.Collections.Generic;
3+
using System.Drawing;
4+
using System.Windows.Forms;
5+
6+
namespace WinFormsApp1.Controls
7+
{
8+
public partial class CharacterStatsDisplayControl : UserControl
9+
{
10+
private Label statsLabel;
11+
12+
public CharacterStatsDisplayControl()
13+
{
14+
InitializeComponent();
15+
}
16+
17+
private void InitializeComponent()
18+
{
19+
this.Size = new Size(350, 230);
20+
this.BackColor = Color.LightGray;
21+
this.BorderStyle = BorderStyle.FixedSingle;
22+
23+
statsLabel = new Label
24+
{
25+
Dock = DockStyle.Fill,
26+
Font = new Font("Consolas", 9),
27+
Text = "Select a character class to view stats...",
28+
BackColor = Color.LightGray,
29+
TextAlign = ContentAlignment.TopLeft,
30+
Padding = new Padding(10)
31+
};
32+
33+
this.Controls.Add(statsLabel);
34+
}
35+
36+
public void UpdateDisplay(CharacterClassInfo classInfo, DataLoader dataLoader)
37+
{
38+
if (classInfo == null)
39+
{
40+
statsLabel.Text = "Select a character class to view stats...";
41+
return;
42+
}
43+
44+
var startingItems = GetStartingItemsDisplay(classInfo, dataLoader);
45+
46+
statsLabel.Text = $"Class: {classInfo.Name}\n\n" +
47+
$"{classInfo.Description}\n\n" +
48+
$"Base Stats:\n" +
49+
$"Health: {classInfo.BaseStats.MaxHealth}\n" +
50+
$"Attack: {classInfo.BaseStats.Attack}\n" +
51+
$"Defense: {classInfo.BaseStats.Defense}\n\n" +
52+
$"Starting Items:\n{startingItems}";
53+
}
54+
55+
private string GetStartingItemsDisplay(CharacterClassInfo classInfo, DataLoader dataLoader)
56+
{
57+
var itemNames = new List<string>();
58+
59+
foreach (var itemId in classInfo.StartingItems)
60+
{
61+
var item = dataLoader.CreateItemFromId(itemId);
62+
itemNames.Add($"• {item?.Name ?? itemId}");
63+
}
64+
65+
return string.Join("\n", itemNames);
66+
}
67+
68+
public void ClearDisplay()
69+
{
70+
statsLabel.Text = "Select a character class to view stats...";
71+
}
72+
}
73+
}

0 commit comments

Comments
 (0)