Skip to content

Commit 36fb59c

Browse files
authored
fix(ci): reorder npm i steps to fix ci for older node versions (#6336)
1 parent 3a5edfa commit 36fb59c

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -133,13 +133,13 @@ jobs:
133133
npm config set loglevel error
134134
shell: bash
135135

136-
- name: Install dependencies
137-
run: npm install
138-
139136
- name: Install Node version specific dev deps
140137
if: ${{ matrix.npm-i != '' }}
141138
run: npm install --save-dev ${{ matrix.npm-i }}
142139

140+
- name: Install dependencies
141+
run: npm install
142+
143143
- name: Remove non-test dependencies
144144
run: npm rm --silent --save-dev connect-redis
145145

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,11 +75,11 @@
7575
"hbs": "4.2.0",
7676
"marked": "0.7.0",
7777
"method-override": "3.0.0",
78-
"mocha": "10.2.0",
78+
"mocha": "^6.2.2",
7979
"morgan": "1.10.0",
80-
"nyc": "15.1.0",
80+
"nyc": "^14.1.1",
8181
"pbkdf2-password": "1.2.1",
82-
"supertest": "6.3.0",
82+
"supertest": "^6.1.6",
8383
"vhost": "~3.0.2"
8484
},
8585
"engines": {

0 commit comments

Comments
 (0)