code style

Author: xiehuc

cmd/mcptools/commands/call.go

@@ -33,36 +33,7 @@ func CallCmd() *cobra.Command {
 				os.Exit(1)
 			}
 
-			cmdArgs := args
-			parsedArgs := []string{}
-			entityName := ""
-
-			i := 0
-			entityExtracted := false
-
-			for i < len(cmdArgs) {
-				switch {
-				case (cmdArgs[i] == FlagFormat || cmdArgs[i] == FlagFormatShort) && i+1 < len(cmdArgs):
-					FormatOption = cmdArgs[i+1]
-					i += 2
-				case (cmdArgs[i] == FlagParams || cmdArgs[i] == FlagParamsShort) && i+1 < len(cmdArgs):
-					ParamsString = cmdArgs[i+1]
-					i += 2
-				case !entityExtracted:
-					entityName = cmdArgs[i]
-					entityExtracted = true
-					i++
-				case cmdArgs[i] == FlagServerLogs:
-					ShowServerLogs = true
-					i++
-				case cmdArgs[i] == FlagVerbose || cmdArgs[i] == FlagVerboseShort:
-					Verbose = true
-					i++
-				default:
-					parsedArgs = append(parsedArgs, cmdArgs[i])
-					i++
-				}
-			}
+			parsedArgs, entityName := parseCallArguments(args)
 
 			if entityName == "" {
 				fmt.Fprintln(os.Stderr, "Error: entity name is required")
@@ -151,3 +122,38 @@ func CallCmd() *cobra.Command {
 		},
 	}
 }
+
+// fix cyclomatic complexity
+func parseCallArguments(args []string) ([]string, string) {
+	cmdArgs := args
+	parsedArgs := []string{}
+	entityName := ""
+
+	i := 0
+	entityExtracted := false
+
+	for i < len(cmdArgs) {
+		switch {
+		case (cmdArgs[i] == FlagFormat || cmdArgs[i] == FlagFormatShort) && i+1 < len(cmdArgs):
+			FormatOption = cmdArgs[i+1]
+			i += 2
+		case (cmdArgs[i] == FlagParams || cmdArgs[i] == FlagParamsShort) && i+1 < len(cmdArgs):
+			ParamsString = cmdArgs[i+1]
+			i += 2
+		case !entityExtracted:
+			entityName = cmdArgs[i]
+			entityExtracted = true
+			i++
+		case cmdArgs[i] == FlagServerLogs:
+			ShowServerLogs = true
+			i++
+		case cmdArgs[i] == FlagVerbose || cmdArgs[i] == FlagVerboseShort:
+			Verbose = true
+			i++
+		default:
+			parsedArgs = append(parsedArgs, cmdArgs[i])
+			i++
+		}
+	}
+	return parsedArgs, entityName
+}

cmd/mcptools/commands/root.go

@@ -36,7 +36,7 @@ var (
 	ParamsString string
 	// ShowServerLogs is a flag to show server logs.
 	ShowServerLogs bool
-	// Show http verbose info.
+	// Verbose show http verbose info.
 	Verbose bool
 )
 

cmd/mcptools/commands/trace.go

@@ -12,7 +12,7 @@ import (
 
 func generateTraceID() [16]byte {
 	var traceID [16]byte
-	rand.Read(traceID[:])
+	_, _ = rand.Read(traceID[:])
 	return traceID
 }
 

cmd/mcptools/commands/version.go

@@ -10,7 +10,7 @@ import (
 // Version information placeholder.
 var Version = "dev"
 
-// getHomeDirectory returns the user's home directory
+// getHomeDirectory returns the user's home directory.
 // Tries HOME first, then falls back to USERPROFILE for Windows.
 func getHomeDirectory() string {
 	homeDir := os.Getenv("HOME")