Skip to content

Conversation

@johnsteele
Copy link
Collaborator

…documents.

@johnsteele johnsteele force-pushed the master branch 3 times, most recently from f62acc7 to 67ec35a Compare August 29, 2024 18:32
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.47%. Comparing base (34028b5) to head (cf021fd).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/config.ts 50.00% 0 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #734      +/-   ##
==========================================
- Coverage   98.97%   98.47%   -0.50%     
==========================================
  Files          13       13              
  Lines         390      394       +4     
  Branches       52       54       +2     
==========================================
+ Hits          386      388       +2     
  Misses          3        3              
- Partials        1        3       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ruromero ruromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnsteele this seems like a very reasonable option to allow users disable the analysis each time a manifest file is saved but as it is a breaking change I would suggest to enable it by default.

@ruromero ruromero force-pushed the master branch 3 times, most recently from 0ed5f8f to 7d96fcf Compare May 30, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants