Skip to content

Conversation

@sebmarkbage
Copy link
Collaborator

In #34524 we started moving debug info from the Chunk to its inner value (e.g. lazy or array). That way it's not duplicated when the outer one is rendered and not missing when just the value is rendered.

However, we forgot that the component performance track only looks for this debugInfo recursively on the Chunks. This makes it look for it on the value if it can't find it on the chunk.

Flight fixture now logs the components again.

@meta-cla meta-cla bot added the CLA Signed label Oct 14, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Oct 14, 2025
@react-sizebot
Copy link

Comparing: b9ec735...a3010b5

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 605.41 kB 605.41 kB = 107.21 kB 107.21 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 664.38 kB 664.38 kB = 117.09 kB 117.09 kB
facebook-www/ReactDOM-prod.classic.js = 688.25 kB 688.25 kB = 121.13 kB 121.13 kB
facebook-www/ReactDOM-prod.modern.js = 678.67 kB 678.67 kB = 119.48 kB 119.48 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against a3010b5

Copy link
Collaborator

@unstubbable unstubbable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I focussed too much on the Components tab when implementing #34524. Should have checked the performance track as well. Thanks for fixing it!

@eps1lon eps1lon merged commit 03a62b2 into facebook:main Oct 14, 2025
246 of 247 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants