Merge pull request #404 from facebook/textnode-tapping

secretiverhyme · secretiverhyme · commit d3a8f440688a · 2015-03-26T18:01:36.000-07:00
Allow double-tap gestures on text nodes
diff --git a/AsyncDisplayKit/ASControlNode.m b/AsyncDisplayKit/ASControlNode.m
@@ -196,7 +196,9 @@ - (BOOL)gestureRecognizerShouldBegin:(UIGestureRecognizer *)gestureRecognizer
 {
   // If we're interested in touches, this is a tap (the only gesture we care about) and passed -hitTest for us, then no, you may not begin. Sir.
   if (self.enabled && [gestureRecognizer isKindOfClass:[UITapGestureRecognizer class]] && gestureRecognizer.view != self.view) {
-    return NO;
+    UITapGestureRecognizer *tapRecognizer = (UITapGestureRecognizer *)gestureRecognizer;
+    // Allow double-tap gestures
+    return tapRecognizer.numberOfTapsRequired != 1;
   }
 
   // Otherwise, go ahead. :]

Original file line number	Diff line number	Diff line change
`@@ -196,7 +196,9 @@ - (BOOL)gestureRecognizerShouldBegin:(UIGestureRecognizer *)gestureRecognizer`
`196`	`196`	`{`
`197`	`197`	`// If we're interested in touches, this is a tap (the only gesture we care about) and passed -hitTest for us, then no, you may not begin. Sir.`
`198`	`198`	`if (self.enabled && [gestureRecognizer isKindOfClass:[UITapGestureRecognizer class]] && gestureRecognizer.view != self.view) {`
`199`		`- return NO;`
	`199`	`+ UITapGestureRecognizer tapRecognizer = (UITapGestureRecognizer )gestureRecognizer;`
	`200`	`+ // Allow double-tap gestures`
	`201`	`+ return tapRecognizer.numberOfTapsRequired != 1;`
`200`	`202`	`}`
`201`	`203`
`202`	`204`	`// Otherwise, go ahead. :]`