Check array size before accessing section - rare crash for improper data source use, de-escalated to messaging nil.

Scott Goodson · Scott Goodson · commit df10f8f19a41 · 2016-01-14T00:25:53.000-08:00
diff --git a/AsyncDisplayKit/Details/ASDataController.mm b/AsyncDisplayKit/Details/ASDataController.mm
@@ -900,7 +900,8 @@ - (NSUInteger)numberOfSections
 - (NSUInteger)numberOfRowsInSection:(NSUInteger)section
 {
   ASDisplayNodeAssertMainThread();
-  return [[self completedNodes][section] count];
+  NSArray *completedNodes = [self completedNodes];
+  return (section < completedNodes.count) ? [completedNodes[section] count] : 0;
 }
 
 - (ASCellNode *)nodeAtIndexPath:(NSIndexPath *)indexPath

Original file line number	Diff line number	Diff line change
`@@ -900,7 +900,8 @@ - (NSUInteger)numberOfSections`
`900`	`900`	`- (NSUInteger)numberOfRowsInSection:(NSUInteger)section`
`901`	`901`	`{`
`902`	`902`	`ASDisplayNodeAssertMainThread();`
`903`		`- return [[self completedNodes][section] count];`
	`903`	`+ NSArray *completedNodes = [self completedNodes];`
	`904`	`+ return (section < completedNodes.count) ? [completedNodes[section] count] : 0;`
`904`	`905`	`}`
`905`	`906`
`906`	`907`	`- (ASCellNode )nodeAtIndexPath:(NSIndexPath )indexPath`