fix string reuse in kvstore Entry.String()

joeshaw · peterbourgon · web-flow · commit 28fe9edb6cb3 · 2023-05-15T15:57:48.000-04:00
Co-authored-by: Peter Bourgon &lt;peterbourgon@users.noreply.github.com&gt;
diff --git a/kvstore/kvstore.go b/kvstore/kvstore.go
@@ -27,10 +27,9 @@ func (e *Entry) String() string {
 		return ""
 	}
 
+	e.s = string(b)
 	e.validString = true
-
-	return string(b)
-
+	return e.s
 }
 
 // Store represents a Fastly kv store

Original file line number	Diff line number	Diff line change
`@@ -27,10 +27,9 @@ func (e *Entry) String() string {`
`27`	`27`	`return ""`
`28`	`28`	`}`
`29`	`29`
	`30`	`+ e.s = string(b)`
`30`	`31`	`e.validString = true`
`31`		`-`
`32`		`- return string(b)`
`33`		`-`
	`32`	`+ return e.s`
`34`	`33`	`}`
`35`	`34`
`36`	`35`	`// Store represents a Fastly kv store`