Merge pull request #117 from fastly/cw/buflen

Use known and adaptive buffer sizes to lower generated garbage

Author: cee-dub

.github/actions/install-tinygo/action.yml

@@ -10,7 +10,7 @@ runs:
   steps:
     - run: |
         echo "Install TinyGo ${{ inputs.tinygo-version }}..."
-        wget https://github.com/tinygo-org/tinygo/releases/download/v${{ inputs.tinygo-version }}/tinygo_${{ inputs.tinygo-version }}_amd64.deb
+        wget --no-verbose https://github.com/tinygo-org/tinygo/releases/download/v${{ inputs.tinygo-version }}/tinygo_${{ inputs.tinygo-version }}_amd64.deb
         sudo dpkg -i tinygo_${{ inputs.tinygo-version }}_amd64.deb
         echo "/usr/local/tinygo/bin" >> $GITHUB_PATH
       shell: "bash"

fsthttp/limits.go

@@ -29,21 +29,23 @@ func (limits *Limits) SetMaxHeaderValueLen(len int) {
 }
 
 // MaxMethodLen gets the request method limit
+// Deprecated: the limit is not enforced, buffer sizing is adaptive.
 func (limits *Limits) MaxMethodLen() int {
 	return limits.maxMethodLen
 }
 
 // SetMaxMethodLen sets the request method limit
-func (limits *Limits) SetMaxMethodLen(len int) {
-	limits.maxMethodLen = len
+// Deprecated: the limit is not reset, buffer sizing is adaptive.
+func (limits *Limits) SetMaxMethodLen(_ int) {
 }
 
 // MaxURLLen gets the request URL limit
+// Deprecated: the limit is not enforced, buffer sizing is adaptive.
 func (limits *Limits) MaxURLLen() int {
 	return limits.maxURLLen
 }
 
 // SetMaxURLLen sets the request URL limit
-func (limits *Limits) SetMaxURLLen(len int) {
-	limits.maxURLLen = len
+// Deprecated: the limit is not reset, buffer sizing is adaptive.
+func (limits *Limits) SetMaxURLLen(_ int) {
 }

fsthttp/request.go

@@ -17,10 +17,10 @@ import (
 
 // RequestLimits are the limits for the components of an HTTP request.
 var RequestLimits = Limits{
-	maxHeaderNameLen:  fastly.DefaultMaxHeaderNameLen,
-	maxHeaderValueLen: fastly.DefaultMaxHeaderValueLen,
-	maxMethodLen:      fastly.DefaultMaxMethodLen,
-	maxURLLen:         fastly.DefaultMaxURLLen,
+	maxHeaderNameLen:  fastly.DefaultLargeBufLen,
+	maxHeaderValueLen: fastly.DefaultLargeBufLen,
+	maxMethodLen:      fastly.DefaultMediumBufLen,
+	maxURLLen:         fastly.DefaultLargeBufLen,
 }
 
 // Request represents an HTTP request received by this server from a requesting
@@ -133,12 +133,12 @@ func newClientRequest() (*Request, error) {
 		return nil, fmt.Errorf("get client request and body: %w", err)
 	}
 
-	method, err := abiReq.GetMethod(RequestLimits.maxMethodLen)
+	method, err := abiReq.GetMethod()
 	if err != nil {
 		return nil, fmt.Errorf("get method: %w", err)
 	}
 
-	uri, err := abiReq.GetURI(RequestLimits.maxURLLen)
+	uri, err := abiReq.GetURI()
 	if err != nil {
 		return nil, fmt.Errorf("get URI: %w", err)
 	}

fsthttp/response.go

@@ -12,8 +12,8 @@ import (
 
 // ResponseLimits are the limits for the components of an HTTP response.
 var ResponseLimits = Limits{
-	maxHeaderNameLen:  fastly.DefaultMaxHeaderNameLen,
-	maxHeaderValueLen: fastly.DefaultMaxHeaderValueLen,
+	maxHeaderNameLen:  fastly.DefaultLargeBufLen,
+	maxHeaderValueLen: fastly.DefaultLargeBufLen,
 }
 
 // Response to an outgoing HTTP request made by this server.