Skip to content

Commit 67933cc

Browse files
Standardize artifact naming with architecture info (#1811)
- Update desktop_cd workflow to use consistent naming: - macOS: hyprnote-macos-aarch64.dmg - Linux: hyprnote-linux-x86_64.AppImage - Update S3 paths and GitHub release artifacts - Add Linux download support to web app - Update VersionPlatform type to include appimage-x86_64 This provides consistency across release and staging builds, includes architecture information for clarity, and aligns with Crabnebula's platform naming conventions. Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: yujonglee <[email protected]>
1 parent 18f759c commit 67933cc

File tree

3 files changed

+15
-14
lines changed

3 files changed

+15
-14
lines changed

.github/workflows/desktop_cd.yaml

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -144,9 +144,9 @@ jobs:
144144
- if: ${{ inputs.channel != 'staging' }}
145145
run: |
146146
DMG_FILE=$(find "apps/desktop/src-tauri/target/aarch64-apple-darwin/release/bundle/dmg/" -name "*.dmg" -type f)
147-
cp "$DMG_FILE" "hyprnote.dmg"
148-
aws s3 cp "hyprnote.dmg" \
149-
"s3://hyprnote-build/desktop/${{ needs.compute-version.outputs.version }}/hyprnote.dmg" \
147+
cp "$DMG_FILE" "hyprnote-macos-aarch64.dmg"
148+
aws s3 cp "hyprnote-macos-aarch64.dmg" \
149+
"s3://hyprnote-build/desktop/${{ needs.compute-version.outputs.version }}/hyprnote-macos-aarch64.dmg" \
150150
--endpoint-url ${{ secrets.CLOUDFLARE_R2_ENDPOINT_URL }} \
151151
--region auto
152152
env:
@@ -224,9 +224,9 @@ jobs:
224224
- if: ${{ inputs.channel != 'staging' }}
225225
run: |
226226
APPIMAGE_FILE=$(find "apps/desktop/src-tauri/target/x86_64-unknown-linux-gnu/release/bundle/appimage/" -name "*.AppImage" -type f)
227-
cp "$APPIMAGE_FILE" "hyprnote.AppImage"
228-
aws s3 cp "hyprnote.AppImage" \
229-
"s3://hyprnote-build/desktop/${{ needs.compute-version.outputs.version }}/hyprnote.AppImage" \
227+
cp "$APPIMAGE_FILE" "hyprnote-linux-x86_64.AppImage"
228+
aws s3 cp "hyprnote-linux-x86_64.AppImage" \
229+
"s3://hyprnote-build/desktop/${{ needs.compute-version.outputs.version }}/hyprnote-linux-x86_64.AppImage" \
230230
--endpoint-url ${{ secrets.CLOUDFLARE_R2_ENDPOINT_URL }} \
231231
--region auto
232232
env:
@@ -259,8 +259,8 @@ jobs:
259259
- name: Download macOS DMG from S3
260260
run: |
261261
aws s3 cp \
262-
"s3://hyprnote-build/desktop/${{ needs.compute-version.outputs.version }}/hyprnote.dmg" \
263-
"hyprnote.dmg" \
262+
"s3://hyprnote-build/desktop/${{ needs.compute-version.outputs.version }}/hyprnote-macos-aarch64.dmg" \
263+
"hyprnote-macos-aarch64.dmg" \
264264
--endpoint-url ${{ secrets.CLOUDFLARE_R2_ENDPOINT_URL }} \
265265
--region auto
266266
env:
@@ -270,8 +270,8 @@ jobs:
270270
if: ${{ needs.build-linux.result == 'success' }}
271271
run: |
272272
aws s3 cp \
273-
"s3://hyprnote-build/desktop/${{ needs.compute-version.outputs.version }}/hyprnote.AppImage" \
274-
"hyprnote.AppImage" \
273+
"s3://hyprnote-build/desktop/${{ needs.compute-version.outputs.version }}/hyprnote-linux-x86_64.AppImage" \
274+
"hyprnote-linux-x86_64.AppImage" \
275275
--endpoint-url ${{ secrets.CLOUDFLARE_R2_ENDPOINT_URL }} \
276276
--region auto
277277
env:
@@ -289,12 +289,12 @@ jobs:
289289
tag: desktop_v${{ needs.compute-version.outputs.version }}
290290
name: desktop_v${{ needs.compute-version.outputs.version }}
291291
body: "https://hyprnote.com/changelog/${{ needs.compute-version.outputs.version }}"
292-
artifacts: "hyprnote.dmg"
292+
artifacts: "hyprnote-macos-aarch64.dmg"
293293
- name: Create GitHub release with macOS + Linux
294294
if: ${{ needs.build-linux.result == 'success' }}
295295
uses: ncipollo/release-action@v1
296296
with:
297297
tag: desktop_v${{ needs.compute-version.outputs.version }}
298298
name: desktop_v${{ needs.compute-version.outputs.version }}
299299
body: "https://hyprnote.com/changelog/${{ needs.compute-version.outputs.version }}"
300-
artifacts: "hyprnote.dmg,hyprnote.AppImage"
300+
artifacts: "hyprnote-macos-aarch64.dmg,hyprnote-linux-x86_64.AppImage"

apps/web/content-collections.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,8 @@ const changelog = defineCollection({
110110
const tag = `desktop_v${version}`;
111111

112112
const downloads: Record<VersionPlatform, string> = {
113-
"dmg-aarch64": `https://github.com/fastrepl/hyprnote/releases/download/${tag}/hyprnote.dmg`,
113+
"dmg-aarch64": `https://github.com/fastrepl/hyprnote/releases/download/${tag}/hyprnote-macos-aarch64.dmg`,
114+
"appimage-x86_64": `https://github.com/fastrepl/hyprnote/releases/download/${tag}/hyprnote-linux-x86_64.AppImage`,
114115
};
115116

116117
return {

apps/web/src/scripts/versioning.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { join } from "node:path";
44
type VersionChannel = "stable" | "nightly" | "staging";
55

66
// https://docs.crabnebula.dev/cloud/cli/upload-assets/#public-platform---public-platform
7-
export type VersionPlatform = "dmg-aarch64";
7+
export type VersionPlatform = "dmg-aarch64" | "appimage-x86_64";
88

99
export type VersionDownloads = Partial<Record<VersionPlatform, string>>;
1010

0 commit comments

Comments
 (0)