check if cache directory not empty after closing runtime

Author: danslo

runtime.go

@@ -60,7 +60,7 @@ func createGlobalCompiledModule(
 	// Check if we need to compile or recompile
 	if compiledQJSModule == nil || cachedBytesHash != currentHash || disableBuildCache {
 		var cache wazero.CompilationCache
-		if cacheDir == "" || disableBuildCache {
+		if cacheDir == "" {
 			cache = wazero.NewCompilationCache()
 		} else if cache, err = wazero.NewCompilationCacheWithDir(cacheDir); err != nil {
 			return fmt.Errorf("failed to create compilation cache with dir %s: %w", cacheDir, err)

runtime_test.go

@@ -3,6 +3,7 @@ package qjs_test
 import (
 	"context"
 	"fmt"
+	"os"
 	"sync"
 	"testing"
 	"time"
@@ -257,18 +258,23 @@ func TestRuntime(t *testing.T) {
 	})
 
 	t.Run("CacheDirOption", func(t *testing.T) {
-		rt1, err := qjs.New(qjs.Option{CacheDir: t.TempDir()})
+		cacheDir := t.TempDir()
+		rt1, err := qjs.New(qjs.Option{CacheDir: cacheDir, DisableBuildCache: true})
 		require.NoError(t, err)
-		defer rt1.Close()
 
 		val, err := rt1.Eval("test.js", qjs.Code("21 + 21"))
 		require.NoError(t, err)
 		assert.Equal(t, int32(42), val.Int32())
 		val.Free()
+
+		rt1.Close()
+		entries, err := os.ReadDir(cacheDir)
+		require.NoError(t, err)
+		assert.NotEmpty(t, entries, "Cache directory should not be empty")
 	})
 
 	t.Run("CacheDirWithEmptyString", func(t *testing.T) {
-		rt, err := qjs.New(qjs.Option{CacheDir: ""})
+		rt, err := qjs.New(qjs.Option{CacheDir: "", DisableBuildCache: true})
 		require.NoError(t, err)
 		defer rt.Close()
 
@@ -279,7 +285,7 @@ func TestRuntime(t *testing.T) {
 	})
 
 	t.Run("CacheDirWithInvalidPath", func(t *testing.T) {
-		_, err := qjs.New(qjs.Option{CacheDir: "/invalid/path/that/does/not/exist", QuickJSWasmBytes: []byte("cachedir")})
+		_, err := qjs.New(qjs.Option{CacheDir: "/invalid/path/that/does/not/exist", DisableBuildCache: true})
 		require.Error(t, err)
 		assert.Contains(t, err.Error(), "failed to create compilation cache")
 	})