feat: Added batching to feature server /push to offline store (#5683) #5729
+588
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntkathole
changed the title
|
|
||
| from feast.repo_config import FeastConfigBaseModel | ||
|
|
||
| class OfflinePushBatchingConfig(FeastConfigBaseModel): |
Member
There was a problem hiding this comment.
i think having a config is fine but do we actually need it? we probably could have just passed these as optional args, no?
Contributor
Author
There was a problem hiding this comment.
You're right, I just noticed the FeatureLoggingConfig with 5 fields and decided that for 3 fields it would be justified to also add a config. Do you want me to refactor it to use optional args?
Contributor
Author
There was a problem hiding this comment.
i think having a config is fine but do we actually need it? we probably could have just passed these as optional args, no?
I refactored it as you wanted, so that there is no config. @franciscojavierarceo
jfw-ppi
force-pushed
the
5683-configurable-batching-feature-server-push
branch
5 times, most recently
from
494912d to
107bf09
Compare
jfw-ppi
force-pushed
the
5683-configurable-batching-feature-server-push
branch
from
89a3da0 to
c980db9
Compare
…dev#5683) Signed-off-by: Jacob Weinhold <[email protected]> fix: formatting,l int errors (feast-dev#5683) Signed-off-by: Jacob Weinhold <[email protected]>
Signed-off-by: Jacob Weinhold <[email protected]>
…t-dev#5724) Signed-off-by: Jacob Weinhold <[email protected]>
jfw-ppi
force-pushed
the
5683-configurable-batching-feature-server-push
branch
from
c980db9 to
04dc34f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Added batching configuration for feature_servers /push endpoint for offline store writes
Which issue(s) this PR fixes:
Fixes #5683