Skip to content

Conversation

@Srihari1192
Copy link
Contributor

@Srihari1192 Srihari1192 commented Nov 28, 2025

What this PR does / why we need it:

This PR introduces to enhance Feast Workbench integration connection tests :
Key Changes

  • Added Feast Workbench connection integration tests (feast_wb_connection_integration_test.go) covering both:

    • Kubernetes authentication scenarios
    • Non-authenticated (no-auth) scenarios
  • Renamed Milvus-related Feast Workbench test file for clarity: feast_wb_test.go → feast_wb_milvus_test.go

  • Updated Notebook utility methods required for Workbench and integration test flows.

  • Added Feast instance creation support using: Auth-enabled YAML configuration

  • Permissions file (RBAC) to validate authenticated setup behavior.

Which issue(s) this PR fixes:

Misc

@Srihari1192 Srihari1192 force-pushed the addWbIntegrationTests branch from 74c54eb to 5914f68 Compare December 1, 2025 06:01
@Srihari1192 Srihari1192 marked this pull request as ready for review December 1, 2025 06:02
@Srihari1192 Srihari1192 requested a review from a team as a code owner December 1, 2025 06:02
@jyejare
Copy link
Contributor

jyejare commented Dec 1, 2025

Looks like same test is failing in Mac for Milvus, could you please rectify that ?

@franciscojavierarceo
Copy link
Member

@jyejare i fixed the milvus issue

@Srihari1192 Srihari1192 force-pushed the addWbIntegrationTests branch from 3456fc4 to 20180f3 Compare December 3, 2025 06:52
@ntkathole ntkathole force-pushed the addWbIntegrationTests branch from 20180f3 to 61009d6 Compare December 3, 2025 10:29
Copy link
Contributor

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work!

Also, please make some plans to:

  1. Add/update the tests to validate that the remote write also works and read it back.
  2. There is also a user account token(apart from service account token of nb) passing facility which we can add a test for.

Copy link
Member

@ntkathole ntkathole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ntkathole ntkathole force-pushed the addWbIntegrationTests branch from 61009d6 to 4f9276f Compare December 7, 2025 13:04
@ntkathole ntkathole merged commit b70eda0 into feast-dev:master Dec 7, 2025
5 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants