Skip to content

Commit 28414cb

Browse files
committed
Device
1 parent aef1ac6 commit 28414cb

File tree

8 files changed

+266
-317
lines changed

8 files changed

+266
-317
lines changed

FirebaseRemoteConfig/Sources/FIRRemoteConfig.m

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,10 @@
2828
#import "FirebaseRemoteConfig/Sources/RCNConfigExperiment.h"
2929
#import "FirebaseRemoteConfig/Sources/RCNConfigRealtime.h"
3030
#import "FirebaseRemoteConfig/Sources/RCNConfigValue_Internal.h"
31-
#import "FirebaseRemoteConfig/Sources/RCNDevice.h"
3231
#import "FirebaseRemoteConfig/Sources/RCNPersonalization.h"
3332

33+
#import "FirebaseRemoteConfig/FirebaseRemoteConfig-Swift.h"
34+
3435
/// Remote Config Error Domain.
3536
/// TODO: Rename according to obj-c style for constants.
3637
NSString *const FIRRemoteConfigErrorDomain = @"com.google.remoteconfig.ErrorDomain";

FirebaseRemoteConfig/Sources/RCNConfigFetch.m

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,9 @@
2424
#import "FirebaseRemoteConfig/Sources/RCNConfigConstants.h"
2525
#import "FirebaseRemoteConfig/Sources/RCNConfigContent.h"
2626
#import "FirebaseRemoteConfig/Sources/RCNConfigExperiment.h"
27-
#import "FirebaseRemoteConfig/Sources/RCNDevice.h"
27+
28+
#import "FirebaseRemoteConfig/FirebaseRemoteConfig-Swift.h"
29+
2830
@import FirebaseRemoteConfigInterop;
2931

3032
#ifdef RCN_STAGING_SERVER
@@ -134,8 +136,8 @@ - (void)fetchConfigWithExpirationDuration:(NSTimeInterval)expirationDuration
134136
completionHandler:
135137
(_Nullable FIRRemoteConfigFetchCompletion)completionHandler {
136138
// Note: We expect the googleAppID to always be available.
137-
BOOL hasDeviceContextChanged =
138-
FIRRemoteConfigHasDeviceContextChanged(_settings.deviceContext, _options.googleAppID);
139+
BOOL hasDeviceContextChanged = [Device remoteConfigHasDeviceContextChanged:_settings.deviceContext
140+
projectIdentifier:_options.googleAppID];
139141

140142
__weak RCNConfigFetch *weakSelf = self;
141143
dispatch_async(_lockQueue, ^{
@@ -201,8 +203,8 @@ - (void)fetchConfigWithExpirationDuration:(NSTimeInterval)expirationDuration
201203
- (void)realtimeFetchConfigWithNoExpirationDuration:(NSInteger)fetchAttemptNumber
202204
completionHandler:(RCNConfigFetchCompletion)completionHandler {
203205
// Note: We expect the googleAppID to always be available.
204-
BOOL hasDeviceContextChanged =
205-
FIRRemoteConfigHasDeviceContextChanged(_settings.deviceContext, _options.googleAppID);
206+
BOOL hasDeviceContextChanged = [Device remoteConfigHasDeviceContextChanged:_settings.deviceContext
207+
projectIdentifier:_options.googleAppID];
206208

207209
__weak RCNConfigFetch *weakSelf = self;
208210
dispatch_async(_lockQueue, ^{

FirebaseRemoteConfig/Sources/RCNConfigRealtime.m

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
#import "FirebaseRemoteConfig/Sources/Private/RCNConfigFetch.h"
2424
#import "FirebaseRemoteConfig/Sources/Private/RCNConfigSettings.h"
2525
#import "FirebaseRemoteConfig/Sources/RCNConfigConstants.h"
26-
#import "FirebaseRemoteConfig/Sources/RCNDevice.h"
2726

2827
/// URL params
2928
static NSString *const kServerURLDomain = @"https://firebaseremoteconfigrealtime.googleapis.com";
@@ -329,7 +328,7 @@ - (void)createRequestBodyWithCompletion:(void (^)(NSData *_Nonnull requestBody))
329328
@"sdkVersion:'%@', appInstanceId:'%@'}",
330329
[strongSelf->_options GCMSenderID], namespace,
331330
strongSelf->_configFetch.templateVersionNumber,
332-
strongSelf->_options.googleAppID, FIRRemoteConfigPodVersion(),
331+
strongSelf->_options.googleAppID, Device.remoteConfigPodVersion,
333332
strongSelf->_settings.configInstallationsIdentifier];
334333
NSData *postData = [postBody dataUsingEncoding:NSUTF8StringEncoding];
335334
NSError *compressionError;

FirebaseRemoteConfig/Sources/RCNConfigSettings.m

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
#import "FirebaseRemoteConfig/Sources/RCNConfigConstants.h"
2222
#import "FirebaseRemoteConfig/Sources/RCNConfigDBManager.h"
2323
#import "FirebaseRemoteConfig/Sources/RCNConfigValue_Internal.h"
24-
#import "FirebaseRemoteConfig/Sources/RCNDevice.h"
2524

2625
#import <GoogleUtilities/GULAppEnvironmentUtil.h>
2726
#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
@@ -293,7 +292,7 @@ - (void)updateMetadataWithFetchSuccessStatus:(BOOL)fetchSuccess
293292
if (fetchSuccess) {
294293
[self updateLastFetchTimeInterval:[[NSDate date] timeIntervalSince1970]];
295294
// Note: We expect the googleAppID to always be available.
296-
_deviceContext = FIRRemoteConfigDeviceContextWithProjectIdentifier(_googleAppID);
295+
_deviceContext = [[Device remoteConfigDeviceContextWith:_googleAppID] mutableCopy];
297296
_lastFetchedTemplateVersion = templateVersion;
298297
[_userDefaultsManager setLastFetchedTemplateVersion:templateVersion];
299298
}
@@ -398,23 +397,25 @@ - (NSString *)nextRequestWithUserProperties:(NSDictionary *)userProperties {
398397
_configInstallationsToken]];
399398
ret = [ret stringByAppendingString:[NSString stringWithFormat:@", app_id:'%@'", _googleAppID]];
400399

401-
ret = [ret stringByAppendingString:[NSString stringWithFormat:@", country_code:'%@'",
402-
FIRRemoteConfigDeviceCountry()]];
400+
ret =
401+
[ret stringByAppendingString:[NSString stringWithFormat:@", country_code:'%@'",
402+
[Device remoteConfigDeviceCountry]]];
403403
ret = [ret stringByAppendingString:[NSString stringWithFormat:@", language_code:'%@'",
404-
FIRRemoteConfigDeviceLocale()]];
404+
[Device remoteConfigDeviceLocale]]];
405405
ret = [ret
406406
stringByAppendingString:[NSString stringWithFormat:@", platform_version:'%@'",
407407
[GULAppEnvironmentUtil systemVersion]]];
408408
ret = [ret stringByAppendingString:[NSString stringWithFormat:@", time_zone:'%@'",
409-
FIRRemoteConfigTimezone()]];
409+
[Device remoteConfigTimezone]]];
410410
ret = [ret stringByAppendingString:[NSString stringWithFormat:@", package_name:'%@'",
411411
_bundleIdentifier]];
412412
ret = [ret stringByAppendingString:[NSString stringWithFormat:@", app_version:'%@'",
413-
FIRRemoteConfigAppVersion()]];
414-
ret = [ret stringByAppendingString:[NSString stringWithFormat:@", app_build:'%@'",
415-
FIRRemoteConfigAppBuildVersion()]];
413+
[Device remoteConfigAppVersion]]];
414+
ret = [ret
415+
stringByAppendingString:[NSString stringWithFormat:@", app_build:'%@'",
416+
[Device remoteConfigAppBuildVersion]]];
416417
ret = [ret stringByAppendingString:[NSString stringWithFormat:@", sdk_version:'%@'",
417-
FIRRemoteConfigPodVersion()]];
418+
[Device remoteConfigPodVersion]]];
418419

419420
if (userProperties && userProperties.count > 0) {
420421
NSError *error;

FirebaseRemoteConfig/Sources/RCNDevice.h

Lines changed: 0 additions & 57 deletions
This file was deleted.

0 commit comments

Comments
 (0)