fix: Resolve build warnings, move test target, check in new test scheme (#15518)

Author: ncooke3

.github/workflows/firestore.yml

@@ -514,9 +514,8 @@ jobs:
   spm-binary:
     uses: ./.github/workflows/common.yml
     with:
-      target: FirebaseFirestore
+      target: FirebaseFirestoreTests
       platforms: iOS
-      buildonly_platforms: iOS
 
   check-firestore-internal-public-headers:
     needs: check

Firestore/Swift/Tests/Unit/AsyncAwait/AsyncSequenceTests.swift

@@ -123,7 +123,7 @@ private struct Swizzler: ~Copyable {
                               swizzledSelector: Selector) {
     guard let originalMethod = class_getInstanceMethod(cls, originalSelector),
           let swizzledMethod = class_getInstanceMethod(cls, swizzledSelector) else {
-      #expect(false, "Failed to get methods for swizzling")
+      #expect(Bool(false), "Failed to get methods for swizzling")
       return
     }
     method_exchangeImplementations(originalMethod, swizzledMethod)
@@ -230,7 +230,7 @@ struct QueryAsyncSequenceTests {
 
     let task = Task {
       for try await _ in query.snapshots {
-        #expect(false, "The stream should not have produced any values.")
+        #expect(Bool(false), "The stream should not have produced any values.")
       }
     }
 
@@ -350,7 +350,7 @@ struct DocumentReferenceAsyncSequenceTests {
 
     let task = Task {
       for try await _ in docRef.snapshots {
-        #expect(false, "The stream should not have produced any values.")
+        #expect(Bool(false), "The stream should not have produced any values.")
       }
     }
 
@@ -398,4 +398,4 @@ extension DocumentReference {
   }
 }
 
-extension String: Error {}
+extension String: @retroactive Error {}

Package.swift

@@ -1377,6 +1377,18 @@ let package = Package(
         .headerSearchPath("../../.."),
       ]
     ),
+    .testTarget(
+      name: "FirebaseFirestoreTests",
+      dependencies: [
+        "Firebase",
+        "FirebaseCore",
+        "FirebaseFirestoreTarget",
+      ],
+      path: "Firestore/Swift/Tests/Unit",
+      cSettings: [
+        .headerSearchPath("../../../"),
+      ]
+    ),
   ] + firestoreTargets(),
   cxxLanguageStandard: CXXLanguageStandard.gnucxx14
 )
@@ -1552,18 +1564,6 @@ func firestoreTargets() -> [Target] {
           .swiftLanguageMode(SwiftLanguageMode.v5),
         ]
       ),
-      .testTarget(
-        name: "FirebaseFirestoreTests",
-        dependencies: [
-          "Firebase",
-          "FirebaseCore",
-          "FirebaseFirestoreTarget",
-        ],
-        path: "Firestore/Swift/Tests/Unit",
-        cSettings: [
-          .headerSearchPath("../../../"),
-        ]
-      ),
     ]
   }
 

scripts/spm_test_schemes/FirebaseFirestoreTests.xcscheme

@@ -0,0 +1,54 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<Scheme
+   LastUpgradeVersion = "1630"
+   version = "1.7">
+   <BuildAction
+      parallelizeBuildables = "YES"
+      buildImplicitDependencies = "YES"
+      buildArchitectures = "Automatic">
+   </BuildAction>
+   <TestAction
+      buildConfiguration = "Debug"
+      selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
+      selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
+      shouldUseLaunchSchemeArgsEnv = "YES"
+      shouldAutocreateTestPlan = "YES">
+      <Testables>
+         <TestableReference
+            skipped = "NO">
+            <BuildableReference
+               BuildableIdentifier = "primary"
+               BlueprintIdentifier = "FirebaseFirestoreTests"
+               BuildableName = "FirebaseFirestoreTests"
+               BlueprintName = "FirebaseFirestoreTests"
+               ReferencedContainer = "container:">
+            </BuildableReference>
+         </TestableReference>
+      </Testables>
+   </TestAction>
+   <LaunchAction
+      buildConfiguration = "Debug"
+      selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
+      selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
+      launchStyle = "0"
+      useCustomWorkingDirectory = "NO"
+      ignoresPersistentStateOnLaunch = "NO"
+      debugDocumentVersioning = "YES"
+      debugServiceExtension = "internal"
+      allowLocationSimulation = "YES">
+   </LaunchAction>
+   <ProfileAction
+      buildConfiguration = "Release"
+      shouldUseLaunchSchemeArgsEnv = "YES"
+      savedToolIdentifier = ""
+      useCustomWorkingDirectory = "NO"
+      debugDocumentVersioning = "YES">
+   </ProfileAction>
+   <AnalyzeAction
+      buildConfiguration = "Debug">
+   </AnalyzeAction>
+   <ArchiveAction
+      buildConfiguration = "Release"
+      revealArchiveInOrganizer = "YES">
+   </ArchiveAction>
+</Scheme>