Skip to content

Commit 6587027

Browse files
committed
review
1 parent c7e86f1 commit 6587027

File tree

3 files changed

+7
-38
lines changed

3 files changed

+7
-38
lines changed

FirebaseAI/Sources/Types/Public/Schema+FirebaseGenerable.swift

Lines changed: 0 additions & 35 deletions
This file was deleted.

FirebaseAI/Tests/TestApp/Tests/Integration/GenerateContentIntegrationTests.swift

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -295,9 +295,11 @@ struct GenerateContentIntegrationTests {
295295
)
296296

297297
// Expect the call to `generateObject` to fail. If the `maxOutputTokens` setting from the
298-
// parent model's `generationConfig` is correctly inherited, the model's response will be a
299-
// truncated, invalid JSON string, causing the `JSONDecoder` to throw an error. If this test
300-
// fails, it means the configuration was not inherited correctly.
298+
// parent model's `generationConfig` is correctly inherited, the model's response will be
299+
// truncated
300+
// (due to `maxOutputTokens`), causing a `.responseStoppedEarly` error with a `.maxTokens`
301+
// reason
302+
// to be thrown. If this test fails, it means the configuration was not inherited correctly.
301303
do {
302304
_ = try await model.generateObject(
303305
as: Dessert.self,

FirebaseAILogicMacros/Tests/FirebaseAILogicMacroTests/FirebaseAILogicMacroTests.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,8 @@ final class FirebaseGenerableMacroTests: XCTestCase {
4848
"""
4949

5050
assertMacroExpansion(originalSource, expandedSource: expectedSource, macros: macros)
51+
}
52+
5153
func testExpansion_handlesMultiBindingAndComputedProperties() {
5254
let originalSource = """
5355
@FirebaseGenerable

0 commit comments

Comments
 (0)