[RTDB] Fix Fatal Exception: FirebaseDatabasePersistenceFailure

Author: paulb777

FirebaseDatabase/CHANGELOG.md

@@ -1,3 +1,6 @@
+# Unreleased
+- [fixed] Fix `Fatal Exception: FirebaseDatabasePersistenceFailure`. (#4493)
+
 # 11.9.0
 - [fixed] Fix connection failure issue introduced in 10.27.0 by restoring the
   Socket Rocket implementation instead of `NSURLSessionWebSocket`. Note that

FirebaseDatabase/Sources/Persistence/FLevelDBStorageEngine.m

@@ -978,16 +978,23 @@ - (id)deserializePrimitive:(NSData *)data {
 
 + (void)ensureDir:(NSString *)path markAsDoNotBackup:(BOOL)markAsDoNotBackup {
     NSError *error;
+    NSDictionary *attributes = @{
+        NSFileProtectionKey :
+            NSFileProtectionCompleteUntilFirstUserAuthentication
+    };
     BOOL success =
         [[NSFileManager defaultManager] createDirectoryAtPath:path
                                   withIntermediateDirectories:YES
-                                                   attributes:nil
+                                                   attributes:attributes
                                                         error:&error];
     if (!success) {
         @throw [NSException
             exceptionWithName:@"FailedToCreatePersistenceDir"
                        reason:@"Failed to create persistence directory."
-                     userInfo:@{@"path" : path}];
+                     userInfo:@{
+                         @"path" : path,
+                         @"error" : error ? error : [NSNull null]
+                     }];
     }
 
     if (markAsDoNotBackup) {
@@ -1000,9 +1007,6 @@ + (void)ensureDir:(NSString *)path markAsDoNotBackup:(BOOL)markAsDoNotBackup {
                 @"I-RDB076035",
                 @"Failed to mark firebase database folder as do not backup: %@",
                 error);
-            [NSException raise:@"Error marking as do not backup"
-                        format:@"Failed to mark folder %@ as do not backup",
-                               firebaseDirURL];
         }
     }
 }

FirebaseDatabase/Tests/Unit/FLevelDBStorageEngineTests.m

@@ -25,8 +25,11 @@
 #import "FirebaseDatabase/Sources/Snapshot/FSnapshotUtilities.h"
 #import "FirebaseDatabase/Tests/Helpers/FTestHelpers.h"
 
-@interface FLevelDBStorageEngineTests : XCTestCase
+@interface FLevelDBStorageEngine (Tests)
++ (void)ensureDir:(NSString *)path markAsDoNotBackup:(BOOL)markAsDoNotBackup;
+@end
 
+@interface FLevelDBStorageEngineTests : XCTestCase
 @end
 
 @implementation FLevelDBStorageEngineTests
@@ -685,4 +688,36 @@ - (void)testRemoveTrackedQueryRemovesTrackedQueryKeys {
                         ([NSSet setWithArray:@[ @"b", @"c" ]]));
 }
 
+- (void)testEnsureDirSetsCorrectFileProtection {
+    NSString *testDirName =
+        [NSString stringWithFormat:@"fdb_persistence_test_%lu", (unsigned long)arc4random()];
+    NSString *testPath = [NSTemporaryDirectory() stringByAppendingPathComponent:testDirName];
+
+    // Ensure the directory doesn't exist before the test
+    [[NSFileManager defaultManager] removeItemAtPath:testPath error:nil];
+
+    // Call the method to create the directory
+    [FLevelDBStorageEngine ensureDir:testPath markAsDoNotBackup:NO];
+
+    // Get the attributes of the created directory
+    NSError *error = nil;
+    NSDictionary<NSFileAttributeKey, id> *attributes =
+        [[NSFileManager defaultManager] attributesOfItemAtPath:testPath error:&error];
+
+    // Assert that the file protection attribute is correct
+    XCTAssertNil(error, @"Failed to get attributes of directory: %@", error);
+
+#if TARGET_OS_IPHONE && !TARGET_OS_SIMULATOR
+    // On a physical iOS device, file protection should be set.
+    XCTAssertEqualObjects(attributes[NSFileProtectionKey],
+                          NSFileProtectionCompleteUntilFirstUserAuthentication);
+#else
+    // In the simulator or on other platforms, file protection is not supported, so the key
+    // should be nil.
+    XCTAssertNil(attributes[NSFileProtectionKey]);
+#endif
+
+    // Clean up
+    [[NSFileManager defaultManager] removeItemAtPath:testPath error:nil];
+}
 @end