fixes

paulb777 · paulb777 · commit b02ab711c8d4 · 2024-10-26T09:16:13.000-07:00
diff --git a/Crashlytics/UnitTests/FIRCLSMetricKitManagerTests.m b/Crashlytics/UnitTests/FIRCLSMetricKitManagerTests.m
@@ -16,7 +16,11 @@
 #import <XCTest/XCTest.h>
 
 #import "Crashlytics/Crashlytics/Controllers/FIRCLSMetricKitManager.h"
+
 @import FirebaseCoreInternal;
+#if SWIFT_PACKAGE
+@import FirebaseCoreInternalObjC;
+#endif
 
 #if CLS_METRICKIT_SUPPORTED
 
diff --git a/Crashlytics/UnitTests/FIRCLSOnDemandModelTests.m b/Crashlytics/UnitTests/FIRCLSOnDemandModelTests.m
@@ -34,6 +34,9 @@
 #import "Crashlytics/Crashlytics/Settings/Models/FIRCLSApplicationIdentifierModel.h"
 
 @import FirebaseCoreInternal;
+#if SWIFT_PACKAGE
+@import FirebaseCoreInternalObjC;
+#endif
 
 #define TEST_GOOGLE_APP_ID (@"1:632950151350:ios:d5b0d08d4f00f4b1")
 
diff --git a/Crashlytics/UnitTests/FIRCLSReportManagerTests.m b/Crashlytics/UnitTests/FIRCLSReportManagerTests.m
@@ -16,6 +16,9 @@
 #import <XCTest/XCTest.h>
 
 @import FirebaseCoreInternal;
+#if SWIFT_PACKAGE
+@import FirebaseCoreInternalObjC;
+#endif
 
 #if __has_include(<FBLPromises/FBLPromises.h>)
 #import <FBLPromises/FBLPromises.h>
diff --git a/FirebaseABTesting.podspec b/FirebaseABTesting.podspec
@@ -41,7 +41,6 @@ Firebase Cloud Messaging and Firebase Remote Config in your app.
   s.source_files = [
     base_dir + '**/*.[mh]',
    'Interop/Analytics/Public/*.h',
-   'FirebaseCore/Extension/*.h',
   ]
   s.resource_bundles = {
     "#{s.module_name}_Privacy" => 'FirebaseABTesting/Sources/Resources/PrivacyInfo.xcprivacy'
@@ -53,6 +52,7 @@ Firebase Cloud Messaging and Firebase Remote Config in your app.
     'HEADER_SEARCH_PATHS' => '"${PODS_TARGET_SRCROOT}"'
   }
   s.dependency 'FirebaseCore', '11.5'
+  s.dependency 'FirebaseCoreExtension', '11.5'
 
   s.test_spec 'unit' do |unit_tests|
     unit_tests.scheme = { :code_coverage => true }
diff --git a/FirebaseAppCheck.podspec b/FirebaseAppCheck.podspec
@@ -36,7 +36,6 @@ Pod::Spec.new do |s|
 
   s.source_files = [
     base_dir + 'Sources/**/*.[mh]',
-    'FirebaseCore/Extension/*.h',
   ]
   s.public_header_files = base_dir + 'Sources/Public/FirebaseAppCheck/*.h'
 
@@ -47,6 +46,7 @@ Pod::Spec.new do |s|
   s.dependency 'AppCheckCore', '~> 11.0'
   s.dependency 'FirebaseAppCheckInterop', '~> 11.0'
   s.dependency 'FirebaseCore', '11.5'
+  s.dependency 'FirebaseCoreExtension', '11.5'
   s.dependency 'GoogleUtilities/Environment', '~> 8.0'
   s.dependency 'GoogleUtilities/UserDefaults', '~> 8.0'
 
diff --git a/FirebaseAppCheck/Sources/DeviceCheckProvider/FIRDeviceCheckProvider.m b/FirebaseAppCheck/Sources/DeviceCheckProvider/FIRDeviceCheckProvider.m
@@ -26,6 +26,7 @@
 #import "FirebaseAppCheck/Sources/Core/FIRAppCheckValidator.h"
 #import "FirebaseAppCheck/Sources/Core/FIRHeartbeatLogger+AppCheck.h"
 
+@import FirebaseCoreExtension;
 @import FirebaseCoreInternal;
 #if SWIFT_PACKAGE
 @import FirebaseCoreInternalObjC;
diff --git a/FirebaseCore.podspec b/FirebaseCore.podspec
@@ -52,7 +52,6 @@ Firebase Core includes FIRApp and FIROptions which provide central configuration
 
   # Remember to also update version in `cmake/external/GoogleUtilities.cmake`
   s.dependency 'GoogleUtilities/Environment', '~> 8.0'
-  s.dependency 'GoogleUtilities/Logger', '~> 8.0'
   s.dependency 'FirebaseCoreInternal', '11.5'
 
   s.pod_target_xcconfig = {
diff --git a/FirebaseCore/Tests/Unit/FIRComponentContainerTest.m b/FirebaseCore/Tests/Unit/FIRComponentContainerTest.m
@@ -14,11 +14,15 @@
 
 #import "FirebaseCore/Tests/Unit/FIRTestCase.h"
 
-#import "FirebaseCore/InternalObjC//FIRComponentType.h"
+#import "FirebaseCore/Extension/FIRAppInternal.h"
+#import "FirebaseCore/InternalObjC/FIRComponentContainer.h"
 #import "FirebaseCore/InternalObjC/FIRComponentContainerInternal.h"
+#import "FirebaseCore/InternalObjC/FIRComponentType.h"
 #import "FirebaseCore/Tests/Unit/FIRTestComponents.h"
 #import "SharedTestUtilities/FIROptionsMock.h"
 
+@import FirebaseCore;
+
 /// Internally exposed methods and properties for testing.
 @interface FIRComponentContainer (TestInternal)
 
diff --git a/FirebaseCore/Tests/Unit/FIRTestComponents.m b/FirebaseCore/Tests/Unit/FIRTestComponents.m
@@ -14,7 +14,11 @@
 
 #import "FirebaseCore/Tests/Unit/FIRTestComponents.h"
 
+#import "FirebaseCore/Extension/FIRAppInternal.h"
+#import "FirebaseCore/InternalObjC/FIRComponentContainer.h"
+#import "FirebaseCore/InternalObjC/FIRComponentContainerInternal.h"
 #import "FirebaseCore/InternalObjC/FIRComponentType.h"
+#import "FirebaseCore/Tests/Unit/FIRTestComponents.h"
 
 #pragma mark - Standard Component
 
diff --git a/FirebaseCoreInternal.podspec b/FirebaseCoreInternal.podspec
@@ -39,6 +39,8 @@ Pod::Spec.new do |s|
 
   s.swift_version = '5.9'
 
+  s.dependency 'GoogleUtilities/Environment', '~> 8.0'
+  s.dependency 'GoogleUtilities/Logger', '~> 8.0'
   s.dependency 'GoogleUtilities/NSData+zlib', '~> 8.0'
 
   s.pod_target_xcconfig = {
diff --git a/FirebaseDatabase.podspec b/FirebaseDatabase.podspec
@@ -38,7 +38,6 @@ Simplify your iOS development, grow your user base, and monetize more effectivel
     base_dir + 'third_party/Wrap-leveldb/APLevelDB.mm',
     'FirebaseDatabase/Swift/Sources/**/*.swift',
     'FirebaseAuth/Interop/**/*.h',
-    'FirebaseCore/Extension/*.h',
   ]
   s.public_header_files = base_dir + 'Public/FirebaseDatabase/*.h'
   s.libraries = ['c++', 'icucore']
@@ -48,6 +47,7 @@ Simplify your iOS development, grow your user base, and monetize more effectivel
   s.watchos.frameworks = 'CFNetwork', 'Security', 'WatchKit'
   s.dependency 'leveldb-library', '~> 1.22'
   s.dependency 'FirebaseCore', '11.5'
+  s.dependency 'FirebaseCoreExtension', '11.5'
   s.dependency 'FirebaseAppCheckInterop', '~> 11.0'
   s.dependency 'FirebaseSharedSwift', '~> 11.0'
   s.dependency 'GoogleUtilities/UserDefaults', '~> 8.0'
diff --git a/FirebaseRemoteConfig/Tests/Unit/RCNInstanceIDTest.m b/FirebaseRemoteConfig/Tests/Unit/RCNInstanceIDTest.m
@@ -27,10 +27,16 @@
 #import "FirebaseRemoteConfig/Tests/Unit/RCNTestUtilities.h"
 
 #import <GoogleUtilities/GULNSData+zlib.h>
-#import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 #import "FirebaseInstallations/Source/Library/Private/FirebaseInstallationsInternal.h"
 @import FirebaseRemoteConfigInterop;
 
+@import FirebaseCore;
+@import FirebaseCoreExtension;
+@import FirebaseCoreInternal;
+#if SWIFT_PACKAGE
+@import FirebaseCoreInternalObjC;
+#endif
+
 @interface RCNConfigFetch (ForTest)
 - (instancetype)initWithContent:(RCNConfigContent *)content
                       DBManager:(RCNConfigDBManager *)DBManager
diff --git a/Package.swift b/Package.swift
@@ -204,6 +204,8 @@ let package = Package(
       name: "CoreUnit",
       dependencies: [
         "FirebaseCore",
+        "FirebaseCoreExtension",
+        "FirebaseCoreInternalObjC",
         "SharedTestUtilities",
         .product(name: "OCMock", package: "ocmock"),
       ],
@@ -943,6 +945,7 @@ let package = Package(
     .target(
       name: "SharedTestUtilities",
       dependencies: ["FirebaseCore",
+                     "FirebaseCoreInternalObjC",
                      "FirebaseAppCheckInterop",
                      "FirebaseAuthInterop",
                      "FirebaseMessagingInterop",
diff --git a/SharedTestUtilities/FIRComponentTestUtilities.h b/SharedTestUtilities/FIRComponentTestUtilities.h
@@ -16,9 +16,10 @@
 
 #import <Foundation/Foundation.h>
 
-@import FirebaseCoreInternal;
 #if SWIFT_PACKAGE
 @import FirebaseCoreInternalObjC;
+#else
+@import FirebaseCoreInternal;
 #endif
 
 NS_ASSUME_NONNULL_BEGIN
diff --git a/scripts/check_imports.swift b/scripts/check_imports.swift
@@ -121,6 +121,8 @@ private func checkFile(_ file: String, logger: ErrorLogger, inRepo repoURL: URL,
     } else if inSwiftPackage, line.starts(with: "#else") {
       inSwiftPackage = false
       inSwiftPackageElse = true
+    } else if inSwiftPackage, line.starts(with: "#endif") {
+      inSwiftPackage = false
     } else if inSwiftPackageElse, line.starts(with: "#endif") {
       inSwiftPackageElse = false
     } else if inSwiftPackage {

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,6 @@ Firebase Cloud Messaging and Firebase Remote Config in your app.`
`41`	`41`	`s.source_files = [`
`42`	`42`	`base_dir + '*/.[mh]',`
`43`	`43`	`'Interop/Analytics/Public/*.h',`
`44`		`- 'FirebaseCore/Extension/*.h',`
`45`	`44`	`]`
`46`	`45`	`s.resource_bundles = {`
`47`	`46`	`"#{s.module_name}_Privacy" => 'FirebaseABTesting/Sources/Resources/PrivacyInfo.xcprivacy'`
`@@ -53,6 +52,7 @@ Firebase Cloud Messaging and Firebase Remote Config in your app.`
`53`	`52`	`'HEADER_SEARCH_PATHS' => '"${PODS_TARGET_SRCROOT}"'`
`54`	`53`	`}`
`55`	`54`	`s.dependency 'FirebaseCore', '11.5'`
	`55`	`+ s.dependency 'FirebaseCoreExtension', '11.5'`
`56`	`56`
`57`	`57`	`s.test_spec 'unit' do \|unit_tests\|`
`58`	`58`	`unit_tests.scheme = { :code_coverage => true }`