better

Author: paulb777

Crashlytics/Crashlytics/Components/FIRCLSBinaryImage.m

@@ -57,23 +57,19 @@ void FIRCLSBinaryImageInit(void) {
   memset(&_firclsContext.writable->binaryImage, 0, sizeof(_firclsContext.writable->binaryImage));
   _firclsContext.writable->binaryImage.file.fd = -1;
 
-  dispatch_async(FIRCLSGetBinaryImageQueue(), ^{
-    if (!FIRCLSUnlinkIfExists(_firclsContext.readonly->binaryimage.path)) {
-      FIRCLSSDKLog("Unable to reset the binary image log file %s\n", strerror(errno));
-    }
+  if (!FIRCLSUnlinkIfExists(_firclsContext.readonly->binaryimage.path)) {
+    FIRCLSSDKLog("Unable to reset the binary image log file %s\n", strerror(errno));
+  }
 
-    bool needsClosing;  // unneeded
-    if (!FIRCLSBinaryImageOpenIfNeeded(&needsClosing)) {
-      FIRCLSSDKLog("Error: Unable to open the binary image log file during init\n");
-    }
-  });
+  bool needsClosing;  // unneeded
+  if (!FIRCLSBinaryImageOpenIfNeeded(&needsClosing)) {
+    FIRCLSSDKLog("Error: Unable to open the binary image log file during init\n");
+  }
+
+  FIRCLSFileClose(&_firclsContext.writable->binaryImage.file);
 
   _dyld_register_func_for_add_image(FIRCLSBinaryImageAddedCallback);
   _dyld_register_func_for_remove_image(FIRCLSBinaryImageRemovedCallback);
-
-  dispatch_async(FIRCLSGetBinaryImageQueue(), ^{
-    FIRCLSFileClose(&_firclsContext.writable->binaryImage.file);
-  });
 }
 
 static bool FIRCLSBinaryImageOpenIfNeeded(bool* needsClosing) {

Crashlytics/UnitTests/FIRCLSContextManagerTests.m

@@ -43,9 +43,9 @@ @implementation FIRCLSContextManagerTests
 - (void)setUp {
   self.fileManager = [[FIRCLSMockFileManager alloc] init];
   [[NSFileManager defaultManager] createDirectoryAtPath:self.fileManager.rootPath
-                              withIntermediateDirectories:YES
-                                               attributes:nil
-                                                    error:nil];
+                            withIntermediateDirectories:YES
+                                             attributes:nil
+                                                  error:nil];
   [self.fileManager createReportDirectories];
   [self.fileManager setupNewPathForExecutionIdentifier:TestContextReportID];