Skip to content

Commit 1801c53

Browse files
committed
Nits.
1 parent cfbcd46 commit 1801c53

File tree

2 files changed

+1
-12
lines changed

2 files changed

+1
-12
lines changed

config/.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
# Uncomment this if you'd like others to create their own Firebase project.

packages/functions/src/service.ts

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -385,7 +385,6 @@ async function streamAtURL(
385385
// Encode any special types, such as dates, in the input data.
386386
data = encode(data);
387387
const body = { data };
388-
389388
// Add a header for the authToken.
390389
const headers: { [key: string]: string } = {};
391390
const context = await functionsInstance.contextProvider.getContext();
@@ -398,7 +397,6 @@ async function streamAtURL(
398397
if (context.appCheckToken !== null) {
399398
headers['X-Firebase-AppCheck'] = context.appCheckToken;
400399
}
401-
402400
headers['Content-Type'] = 'application/json';
403401
headers['Accept'] = 'text/event-stream';
404402

@@ -448,30 +446,26 @@ async function streamAtURL(
448446
}
449447
};
450448
}
451-
452449
let resultResolver: (value: unknown) => void;
453450
let resultRejecter: (reason: unknown) => void;
454451
const resultPromise = new Promise<unknown>((resolve, reject) => {
455452
resultResolver = resolve;
456453
resultRejecter = reject;
457454
});
458-
459455
options?.signal?.addEventListener('abort', () => {
460456
const error = new FunctionsError(
461457
'cancelled',
462458
'Request was cancelled.'
463459
);
464460
resultRejecter(error);
465461
});
466-
467462
const reader = response.body!.getReader();
468463
const rstream = createResponseStream(
469464
reader,
470465
resultResolver!,
471466
resultRejecter!,
472467
options?.signal
473468
);
474-
475469
return {
476470
stream: {
477471
[Symbol.asyncIterator]() {
@@ -500,12 +494,10 @@ function createResponseStream(
500494
): ReadableStream<unknown> {
501495
const processLine = (line: string, controller: ReadableStreamDefaultController): void => {
502496
const match = line.match(responseLineRE);
503-
//
504497
// ignore all other lines (newline, comments, etc.)
505498
if (!match) {
506499
return;
507500
}
508-
509501
const data = match[1];
510502
try {
511503
const jsonData = JSON.parse(data);
@@ -545,7 +537,6 @@ function createResponseStream(
545537
resultRejecter(error);
546538
return Promise.resolve();
547539
}
548-
549540
try {
550541
const { value, done } = await reader.read();
551542
if (done) {
@@ -555,19 +546,16 @@ function createResponseStream(
555546
controller.close();
556547
return;
557548
}
558-
559549
if (signal?.aborted) {
560550
const error = new FunctionsError('cancelled', 'Request was cancelled');
561551
controller.error(error);
562552
resultRejecter(error);
563553
await reader.cancel();
564554
return;
565555
}
566-
567556
currentText += decoder.decode(value, { stream: true });
568557
const lines = currentText.split("\n");
569558
currentText = lines.pop() || '';
570-
571559
for (const line of lines) {
572560
if (line.trim()) {
573561
processLine(line.trim(), controller);

0 commit comments

Comments
 (0)