Test fixes and re-enabling tests for features that were added on backend

Author: MarkDuckworth

packages/firestore/src/lite-api/expressions.ts

@@ -3043,16 +3043,6 @@ export function arrayOffset(
   return fieldOrExpression(array).arrayOffset(valueToDefaultExpr(offset));
 }
 
-/**
- * @beta
- * Creates an Expr that returns a map of all values in the current expression context.
- *
- * @return A new {@code Expr} representing the 'current_context' function.
- */
-export function currentContext(): FunctionExpr {
-  return new FunctionExpr('current_context', []);
-}
-
 /**
  * @beta
  *

packages/firestore/test/integration/api/pipeline.test.ts

@@ -144,7 +144,7 @@ use(chaiAsPromised);
 
 setLogLevel('debug');
 
-const testUnsupportedFeatures = false;
+const testUnsupportedFeatures: boolean | 'only' = false;
 const timestampDeltaMS = 1000;
 
 apiDescribe('Pipelines', persistence => {
@@ -343,8 +343,7 @@ apiDescribe('Pipelines', persistence => {
       expect(snapshot.results.length).to.equal(0);
     });
 
-    // Skipping because __name__ is not currently working in DBE
-    itIf(testUnsupportedFeatures)('full snapshot as expected', async () => {
+    it('full snapshot as expected', async () => {
       const ppl = firestore
         .pipeline()
         .collection(randomCol.path)
@@ -1372,8 +1371,7 @@ apiDescribe('Pipelines', persistence => {
     });
 
     describe('union stage', () => {
-      // __name__ not currently supported by dbe
-      itIf(testUnsupportedFeatures)('run pipeline with union', async () => {
+      it('run pipeline with union', async () => {
         const snapshot = await execute(
           firestore
             .pipeline()
@@ -2366,21 +2364,6 @@ apiDescribe('Pipelines', persistence => {
       expectResults(snapshot, ...expectedResults);
     });
 
-    // TODO: current_context tests with are failing because of b/395937453
-    itIf(testUnsupportedFeatures)('supports currentContext', async () => {
-      const snapshot = await execute(
-        firestore
-          .pipeline()
-          .collection(randomCol.path)
-          .sort(field('rating').descending())
-          .limit(1)
-          .select(currentContext().as('currentContext'))
-      );
-      expectResults(snapshot, {
-        currentContext: 'TODO'
-      });
-    });
-
     it('supports map', async () => {
       const snapshot = await execute(
         firestore

packages/firestore/test/integration/api/query_to_pipeline.test.ts

@@ -55,7 +55,7 @@ use(chaiAsPromised);
 
 setLogLevel('debug');
 
-const testUnsupportedFeatures = false;
+const testUnsupportedFeatures: boolean | 'only' = false;
 
 // This is the Query integration tests from the lite API (no cache support)
 // with some additional test cases added for more complete coverage.
@@ -247,9 +247,7 @@ apiDescribe('Query to Pipeline', persistence => {
     );
   });
 
-  // sort on __name__ is not working
-  itIf(testUnsupportedFeatures)(
-    'supports startAfter (with DocumentSnapshot)',
+  it('supports startAfter (with DocumentSnapshot)',
     () => {
       return withTestCollection(
         PERSISTENCE_MODE_UNSPECIFIED,
@@ -317,9 +315,7 @@ apiDescribe('Query to Pipeline', persistence => {
     }
   );
 
-  // sort on __name__ is not working
-  itIf(testUnsupportedFeatures)(
-    'supports startAt (with DocumentSnapshot)',
+  it('supports startAt (with DocumentSnapshot)',
     () => {
       return withTestCollection(
         PERSISTENCE_MODE_UNSPECIFIED,
@@ -719,8 +715,7 @@ apiDescribe('Query to Pipeline', persistence => {
     );
   });
 
-  // sorting on name required
-  itIf(testUnsupportedFeatures)('supports array contains any', () => {
+  it('supports array contains any', () => {
     return withTestCollection(
       PERSISTENCE_MODE_UNSPECIFIED,
       {