Added fixed error code values to source

Author: MarkDuckworth

packages/firestore/scripts/build-bundle.js

@@ -31,8 +31,7 @@ export function removeAsserts(
 
 /**
  * Transformer that removes all "debugAssert" statements from the SDK and
- * replaces the custom message for fail() and hardAssert() with shorter
- * error codes
+ * removes the custom message for fail() and hardAssert().
  */
 class RemoveAsserts {
   constructor(private readonly typeChecker: ts.TypeChecker) {}
@@ -64,43 +63,22 @@ class RemoveAsserts {
           declaration.getSourceFile().fileName.indexOf(ASSERT_LOCATION) >= 0
         ) {
           const method = declaration.name!.text;
-
           if (method === 'debugAssert') {
             updatedNode = ts.factory.createOmittedExpression();
-          } else if ((method === 'hardAssert') || (method === 'fail')) {
-            const messageIndex = (method === 'hardAssert') ? 1 : 0;
-            if ((node.arguments.length > messageIndex) && (node.arguments[messageIndex].kind === ts.SyntaxKind.StringLiteral)) {
-              const stringLiteral: ts.StringLiteral = node.arguments[messageIndex] as ts.StringLiteral;
-              const errorMessage = RemoveAsserts.trimErrorMessage(stringLiteral.getFullText());
-              const errorCode = RemoveAsserts.errorCode(errorMessage);
-
-              let errorId: number = -1;
-              try {
-                errorId = RemoveAsserts.saveErrorCode(errorCode, errorMessage);
-              }
-              catch (e) {
-                console.log('Failed to save error code ' + JSON.stringify(e));
-              }
-              const newArguments = [...node.arguments];
-              newArguments[messageIndex] = ts.factory.createNumericLiteral(errorId);
-
-              // Replace the call with the full error message to a
-              // build with an error code
-              updatedNode = ts.factory.createCallExpression(
-                declaration.name!,
-                /*typeArgs*/ undefined,
-                newArguments
-              );
-            } else {
-              const newArguments = [...node.arguments];
-              newArguments[messageIndex] = ts.factory.createNumericLiteral(-1);
-              // Remove the log message but keep the assertion
-              updatedNode = ts.factory.createCallExpression(
-                declaration.name!,
-                /*typeArgs*/ undefined,
-                newArguments
-              );
-            }
+          } else if (method === 'hardAssert') {
+            // Remove the log message but keep the assertion
+            updatedNode = ts.factory.createCallExpression(
+              declaration.name!,
+              /*typeArgs*/ undefined,
+              node.arguments.filter(value => !ts.isStringLiteral(value))
+            );
+          } else if (method === 'fail') {
+            // Remove the log message
+            updatedNode = ts.factory.createCallExpression(
+              declaration.name!,
+              /*typeArgs*/ undefined,
+              node.arguments.filter(value => !ts.isStringLiteral(value))
+            );
           }
         }
       }
@@ -113,48 +91,4 @@ class RemoveAsserts {
       return node;
     }
   }
-
-  static trimErrorMessage(errorMessage: string): string {
-    return errorMessage.substring(
-      errorMessage.indexOf("'") + 1,
-      errorMessage.lastIndexOf("'"));
-  }
-
-  static errorCode(errorMessage: string): string {
-    // Create a sha256 hash from the parameter names and types.
-    const hash = createHash('sha256');
-    hash.update(errorMessage);
-
-    // Use the first 7 characters of the hash for a more compact code.
-    const paramHash = hash.digest('hex').substring(0, 7);
-
-    return paramHash;
-  }
-
-
-
-  static saveErrorCode(errorCode: string, errorMessage: string): number {
-    const errorCodes = RemoveAsserts.getErrorCodes();
-
-    const existingErrorCode: Error | undefined = errorCodes[errorCode];
-    if (existingErrorCode)
-      {return existingErrorCode.id;}
-
-    const id = Object.keys(errorCodes).length;
-    errorCodes[errorCode] = {
-      message: errorMessage,
-      id
-    };
-
-    RemoveAsserts.saveErrorCodes(errorCodes);
-
-    return id;
-  }
-
-  static getErrorCodes(): Record<string, Error> {
-    const path = join(module.path, ERROR_CODE_LOCATION);
-    if (!existsSync(path)){
-      return {};
-    }
-    return JSON.parse(readFileSync(path, 'utf-8'));
-  }
+}