Added tests

Author: maneesht

.changeset/gentle-laws-kneel.md

@@ -4,6 +4,7 @@
 "@firebase/database": patch
 "@firebase/firestore": patch
 "@firebase/functions": patch
+"@firebase/storage": patch
 ---
 
 Add SSL checks to `connectDatabaseEmulator` and `connectFirestoreEmulator`

packages/storage/src/api.ts

@@ -359,6 +359,7 @@ export function connectStorageEmulator(
   port: number,
   options: {
     mockUserToken?: EmulatorMockTokenOptions | string;
+    ssl?: boolean;
   } = {}
 ): void {
   connectEmulatorInternal(storage as FirebaseStorageImpl, host, port, options);

packages/storage/src/service.ts

@@ -142,7 +142,7 @@ export function connectStorageEmulator(
   } = {}
 ): void {
   storage.host = `${host}:${port}`;
-  storage._protocol = options.ssl ? 'http' : 'https';
+  storage._protocol = options.ssl ? 'https' : 'http';
   const { mockUserToken } = options;
   if (mockUserToken) {
     storage._overrideAuthToken =

packages/storage/test/unit/service.test.ts

@@ -248,6 +248,27 @@ GOOG4-RSA-SHA256`
       expect(service._protocol).to.equal('http');
       void getDownloadURL(ref(service, 'test.png'));
     });
+    it('sets emulator host correctly with ssl', done => {
+      function newSend(connection: TestingConnection, url: string): void {
+        // Expect emulator host to be in url of storage operations requests,
+        // in this case getDownloadURL.
+        expect(url).to.match(/^https:\/\/test\.host\.org:1234.+/);
+        connection.abort();
+        injectTestConnection(null);
+        done();
+      }
+
+      injectTestConnection(() => newTestConnection(newSend));
+      const service = new FirebaseStorageImpl(
+        testShared.fakeApp,
+        testShared.fakeAuthProvider,
+        testShared.fakeAppCheckTokenProvider
+      );
+      connectStorageEmulator(service, 'test.host.org', 1234, { ssl: true });
+      expect(service.host).to.equal('test.host.org:1234');
+      expect(service._protocol).to.equal('https');
+      void getDownloadURL(ref(service, 'test.png'));
+    });
     it('sets mock user token string if specified', done => {
       const mockUserToken = 'my-mock-user-token';
       function newSend(