Skip to content

Commit a8b208b

Browse files
committed
Updated functions signatures
1 parent d67b284 commit a8b208b

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

common/api-review/functions.api.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { FirebaseApp } from '@firebase/app';
88
import { FirebaseError } from '@firebase/util';
99

1010
// @public
11-
export function connectFunctionsEmulator(functionsInstance: Functions, host: string, port: number): void;
11+
export function connectFunctionsEmulator(functionsInstance: Functions, host: string, port: number, ssl?: boolean): void;
1212

1313
// @public
1414
export interface Functions {

packages/functions/src/api.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,12 +74,14 @@ export function getFunctions(
7474
export function connectFunctionsEmulator(
7575
functionsInstance: Functions,
7676
host: string,
77-
port: number
77+
port: number,
78+
ssl?: boolean
7879
): void {
7980
_connectFunctionsEmulator(
8081
getModularInstance<FunctionsService>(functionsInstance as FunctionsService),
8182
host,
82-
port
83+
port,
84+
ssl
8385
);
8486
}
8587

packages/storage/src/service.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,10 +138,11 @@ export function connectStorageEmulator(
138138
port: number,
139139
options: {
140140
mockUserToken?: EmulatorMockTokenOptions | string;
141+
ssl?: boolean;
141142
} = {}
142143
): void {
143144
storage.host = `${host}:${port}`;
144-
storage._protocol = 'http';
145+
storage._protocol = options.ssl ? 'http' : 'https';
145146
const { mockUserToken } = options;
146147
if (mockUserToken) {
147148
storage._overrideAuthToken =

0 commit comments

Comments
 (0)