Skip to content

Commit c7c099a

Browse files
committed
Try-catch on saveErrorCode
1 parent 53603f3 commit c7c099a

File tree

3 files changed

+40
-1
lines changed

3 files changed

+40
-1
lines changed

packages/firestore/scripts/remove-asserts.js

Lines changed: 17 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/firestore/scripts/remove-asserts.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,12 @@ class RemoveAsserts {
7979
const errorMessage = RemoveAsserts.trimErrorMessage(stringLiteral.getFullText());
8080
const errorCode = RemoveAsserts.errorCode(errorMessage);
8181

82-
RemoveAsserts.saveErrorCode(errorCode, errorMessage);
82+
try {
83+
RemoveAsserts.saveErrorCode(errorCode, errorMessage);
84+
}
85+
catch (e) {
86+
console.log('Failed to save error code ' + JSON.stringify(e));
87+
}
8388
const newArguments = [...node.arguments];
8489
newArguments[messageIndex] = ts.createLiteral(errorCode);
8590

packages/firestore/scripts/run-tests.js

Lines changed: 17 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)