Skip to content

Commit 9760024

Browse files
committed
N-7 remove redundant-getApprovedWorkloads function
This was redundant with the getWorkloadMetadata function, so we remove it to simplify the interface
1 parent 236fd76 commit 9760024

File tree

2 files changed

+3
-21
lines changed

2 files changed

+3
-21
lines changed

src/BlockBuilderPolicy.sol

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -302,14 +302,4 @@ contract BlockBuilderPolicy is
302302
function domainSeparator() external view returns (bytes32) {
303303
return _domainSeparatorV4();
304304
}
305-
306-
/// @inheritdoc IBlockBuilderPolicy
307-
function getApprovedWorkloads(bytes32 workloadId)
308-
external
309-
view
310-
override
311-
returns (string memory commitHash, string[] memory sourceLocators)
312-
{
313-
return (approvedWorkloads[workloadId].commitHash, approvedWorkloads[workloadId].sourceLocators);
314-
}
315305
}

src/interfaces/IBlockBuilderPolicy.sol

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,9 @@ interface IBlockBuilderPolicy {
148148
/// @param workloadId The workload identifier
149149
function removeWorkloadFromPolicy(WorkloadId workloadId) external;
150150

151-
/// @notice Get the metadata for a workload
151+
/// @notice Mapping from workloadId to its metadata (commit hash and source locators)
152+
/// @dev This is only updateable by governance (i.e. the owner) of the Policy contract
153+
/// Adding and removing a workload is O(1)
152154
/// @param workloadId The workload identifier to query
153155
/// @return The metadata associated with the workload
154156
function getWorkloadMetadata(WorkloadId workloadId) external view returns (WorkloadMetadata memory);
@@ -176,16 +178,6 @@ interface IBlockBuilderPolicy {
176178

177179
// ============ Auto-generated getters for public state ============
178180

179-
/// @notice Mapping from workloadId to its metadata (commit hash and source locators)
180-
/// @dev This is only updateable by governance (i.e. the owner) of the Policy contract
181-
/// Adding and removing a workload is O(1).
182-
/// This means the critical `_cachedIsAllowedPolicy` function is O(1) since we can directly check if a workloadId exists
183-
/// in the mapping
184-
function getApprovedWorkloads(bytes32 workloadId)
185-
external
186-
view
187-
returns (string memory commitHash, string[] memory sourceLocators);
188-
189181
/// @notice Address of the FlashtestationRegistry contract that verifies TEE quotes
190182
function registry() external view returns (address);
191183

0 commit comments

Comments
 (0)