Skip to content

Commit 2cc3589

Browse files
authored
fix(python): set default namespace for list/get flags (#357)
Signed-off-by: Mark Phelps <[email protected]>
1 parent 8a5c4c9 commit 2cc3589

File tree

5 files changed

+22
-10
lines changed

5 files changed

+22
-10
lines changed

flipt-python/flipt/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22
from .sync_client import FliptClient
33

44
__all__ = [
5-
"FliptClient",
65
"AsyncFliptClient",
6+
"FliptClient",
77
]

flipt-python/flipt/evaluation/__init__.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,16 @@
1414
from .sync_evaluation_client import Evaluation
1515

1616
__all__ = [
17-
"Evaluation",
1817
"AsyncEvaluation",
19-
"EvaluationResponseType",
20-
"EvaluationReason",
21-
"ErrorEvaluationReason",
22-
"EvaluationRequest",
2318
"BatchEvaluationRequest",
24-
"VariantEvaluationResponse",
19+
"BatchEvaluationResponse",
2520
"BooleanEvaluationResponse",
21+
"ErrorEvaluationReason",
2622
"ErrorEvaluationResponse",
23+
"Evaluation",
24+
"EvaluationReason",
25+
"EvaluationRequest",
2726
"EvaluationResponse",
28-
"BatchEvaluationResponse",
27+
"EvaluationResponseType",
28+
"VariantEvaluationResponse",
2929
]

flipt-python/flipt/flags/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88

99
__all__ = [
1010
"AsyncFlag",
11-
"SyncFlag",
12-
"ListFlagsResponse",
1311
"Flag",
1412
"FlagType",
13+
"ListFlagsResponse",
14+
"SyncFlag",
1515
]

flipt-python/flipt/flags/async_flag_client.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,9 @@ def _raise_on_error(self, response: httpx.Response) -> None:
3838
raise FliptApiError(message, response.status_code)
3939

4040
async def list_flags(self, namespace_key: str, params: ListParameters | None = None) -> ListFlagsResponse:
41+
if namespace_key is None:
42+
namespace_key = "default"
43+
4144
response = await self._client.get(
4245
f"{self.url}/api/v1/namespaces/{namespace_key}/flags",
4346
params=params.model_dump_json(exclude_none=True, by_alias=True) if params else {},
@@ -47,6 +50,9 @@ async def list_flags(self, namespace_key: str, params: ListParameters | None = N
4750
return ListFlagsResponse.model_validate_json(response.text)
4851

4952
async def get_flag(self, namespace_key: str, flag_key: str, params: CommonParameters | None = None) -> Flag:
53+
if namespace_key is None:
54+
namespace_key = "default"
55+
5056
response = await self._client.get(
5157
f"{self.url}/api/v1/namespaces/{namespace_key}/flags/{flag_key}",
5258
params=params.model_dump_json(exclude_none=True, by_alias=True) if params else {},

flipt-python/flipt/flags/sync_flag_client.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,9 @@ def _raise_on_error(self, response: httpx.Response) -> None:
3838
raise FliptApiError(message, response.status_code)
3939

4040
def list_flags(self, namespace_key: str, params: ListParameters | None = None) -> ListFlagsResponse:
41+
if namespace_key is None:
42+
namespace_key = "default"
43+
4144
response = self._client.get(
4245
f"{self.url}/api/v1/namespaces/{namespace_key}/flags",
4346
params=params.model_dump_json(exclude_none=True, by_alias=True) if params else {},
@@ -47,6 +50,9 @@ def list_flags(self, namespace_key: str, params: ListParameters | None = None) -
4750
return ListFlagsResponse.model_validate_json(response.text)
4851

4952
def get_flag(self, namespace_key: str, flag_key: str, params: CommonParameters | None = None) -> Flag:
53+
if namespace_key is None:
54+
namespace_key = "default"
55+
5056
response = self._client.get(
5157
f"{self.url}/api/v1/namespaces/{namespace_key}/flags/{flag_key}",
5258
params=params.model_dump_json(exclude_none=True, by_alias=True) if params else {},

0 commit comments

Comments
 (0)