CodeLens is still shown when disabled in settings

[ali1234]

Fluidd Version

v1.34.4

Browser

Firefox

Device

Desktop PC

Operating System

Linux

What happened

I disabled CodeLens in the editor section of settings. Then I opened a file in the editor and the CodeLens was still visible. Reloading the browser tab did not help.

What did you expect to happen

CodeLens should not be shown if it is disabled.

How to reproduce

1. Go to Settings -> File Editor and turn off the "Show CodeLens" option.
2. Go to Configuration and open any file.

Additional information

This is a regression of #977

[pedrolamas]

Hi @ali1234 thank you for reporting this issue.

I have just attempted to reproduce this issue on my local instance and seems to be working as designed:

Can you try opening the browser Developer Tools (press F12) and check the Console tab there for any errors.

[ali1234]

When I open a file in the editor I see this (and CodeLens is shown):

Uncaught (in promise) Canceled: Canceled
    ll http://voron.lan/assets/setupMonaco-B6oF_ArH.js:9
    cancel http://voron.lan/assets/setupMonaco-B6oF_ArH.js:11
    restore http://voron.lan/assets/setupMonaco.features-XiDAwTTU.js:67
    restoreViewState http://voron.lan/assets/setupMonaco.features-XiDAwTTU.js:67
    restoreViewState http://voron.lan/assets/setupMonaco-B6oF_ArH.js:653
    restoreViewState http://voron.lan/assets/setupMonaco-B6oF_ArH.js:657
    initEditor http://voron.lan/assets/index-CAoDjHKA.js:138
    mounted http://voron.lan/assets/index-CAoDjHKA.js:138
    Ta http://voron.lan/assets/index-CAoDjHKA.js:6
    $i http://voron.lan/assets/index-CAoDjHKA.js:6
    insert http://voron.lan/assets/index-CAoDjHKA.js:6
    ge http://voron.lan/assets/index-CAoDjHKA.js:6
    FF http://voron.lan/assets/index-CAoDjHKA.js:6
    _update http://voron.lan/assets/index-CAoDjHKA.js:6
    s http://voron.lan/assets/index-CAoDjHKA.js:6
    get http://voron.lan/assets/index-CAoDjHKA.js:6
    run http://voron.lan/assets/index-CAoDjHKA.js:6
    _I http://voron.lan/assets/index-CAoDjHKA.js:6
    IS http://voron.lan/assets/index-CAoDjHKA.js:6
    kf http://voron.lan/assets/index-CAoDjHKA.js:6
    promise callback*Nd http://voron.lan/assets/index-CAoDjHKA.js:6
    IS http://voron.lan/assets/index-CAoDjHKA.js:6
    $nextTick http://voron.lan/assets/index-CAoDjHKA.js:6
    beforeDestroy http://voron.lan/assets/index-CAoDjHKA.js:23
    Ta http://voron.lan/assets/index-CAoDjHKA.js:6
    $i http://voron.lan/assets/index-CAoDjHKA.js:6
    $destroy http://voron.lan/assets/index-CAoDjHKA.js:6
    destroy http://voron.lan/assets/index-CAoDjHKA.js:6
    L http://voron.lan/assets/index-CAoDjHKA.js:6
    x http://voron.lan/assets/index-CAoDjHKA.js:6
    W http://voron.lan/assets/index-CAoDjHKA.js:6
    z http://voron.lan/assets/index-CAoDjHKA.js:6
    W http://voron.lan/assets/index-CAoDjHKA.js:6
    z http://voron.lan/assets/index-CAoDjHKA.js:6
    FF http://voron.lan/assets/index-CAoDjHKA.js:6
    _update http://voron.lan/assets/index-CAoDjHKA.js:6
    s http://voron.lan/assets/index-CAoDjHKA.js:6
    get http://voron.lan/assets/index-CAoDjHKA.js:6
    run http://voron.lan/assets/index-CAoDjHKA.js:6
    _I http://voron.lan/assets/index-CAoDjHKA.js:6
    IS http://voron.lan/assets/index-CAoDjHKA.js:6
    kf http://voron.lan/assets/index-CAoDjHKA.js:6
    promise callback*Nd http://voron.lan/assets/index-CAoDjHKA.js:6
    IS http://voron.lan/assets/index-CAoDjHKA.js:6
    $b http://voron.lan/assets/index-CAoDjHKA.js:6
    update http://voron.lan/assets/index-CAoDjHKA.js:6
    notify http://voron.lan/assets/index-CAoDjHKA.js:6
    set http://voron.lan/assets/index-CAoDjHKA.js:6
    setRemoveFileDownload http://voron.lan/assets/index-CAoDjHKA.js:252
    nSe http://voron.lan/assets/index-CAoDjHKA.js:236
[setupMonaco-B6oF_ArH.js:9:628](http://voron.lan/assets/setupMonaco-B6oF_ArH.js)
​```

[pedrolamas]

Can you try on an anonymous window and see if the issue above still happens?

[ali1234]

The console error is not displayed in anon window, but CodeLens is still shown in the editor, and the setting is still set to off.

[pedrolamas]

I still haven't been able to reproduce this issue, so I wonder if there is any issue directly with your local install (either some permission issue on Moonraker side, or a corrupt file on Fluidd side)

[ali1234]

I just upgraded to v1.35.0 and there is no change.

Everything was installed with KIAUH. The moonraker database passed integrity checks and I can see the CodeLens table in the settings store. The moonraker repository is clean.

I first upgraded to 1.35. with KIAUH, and no change.

Then I downloaded the fluidd.zip manually and checked the sha256, then unpacked it and ran a diff. There are more files in the old assets directory but I think these are from the old install I have? They just have different strings of random characters at the end. I guess KIAUH just unzips the new version over the old one without cleaning them up?

Then I replaced the old fluidd directory with the new one I unzipped manually and it still behaves the same.

So I can't find any corruption at all.

This is the first time I have ever upgraded fluidd on this install.

Also I tried it in Chromium (which I never used to access it before) and CodeLens is shown there too.

[pedrolamas]

Thank you for following up on this @ali1234, I am still doing the same myself on my side but so far have been unable to find any way of reproducing this issue.

[ali1234]

I'm fairly comfortable with using browser dev tools and html/css/js so if there is anything you want me to check, no matter how complicated, do feel free to ask.

[pedrolamas]

Considering the error stack you posted above, the Monaco Editor is failing to load correctly, but as far as I can see on their repo, there is nothing related there...

[ali1234]

I cleared session storage and I don't see the above error at all now. So I don't think it is related.

I tried accessing it with Firefox for Android, and I always see CodeLens when requesting desktop site. It doesn't seem to be rendered at all on the mobile version.

[ali1234]

Hmm okay I figured out the problem. CodeLens is not the thing I thought it was.

I thought it was this thing:

But actually it is these:

So this switch is actually working as expected.

[pedrolamas]

Ohh, that's the minimap I think