Update the dependencies used by the site layout #67
Replies: 3 comments 6 replies
-
That doesn't mean it won't happen. And if one of those changes is causes an accessibility issue, not planned, I would hate to have a site on accessibility that doesn't have accessibility first in mind.
Although I'd love to add the Contribute section in WET-BOEW. |
Beta Was this translation helpful? Give feedback.
-
|
Let's vote on it at the next dev meeting. |
Beta Was this translation helpful? Give feedback.
-
|
Will be moving to CDN and taking the WET dependency out of the |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
I would like to suggest to replace the local dependencies of wet-boew and gcweb by the files hosted on the Canada.ca CDN.
Change the line 45-46 in the basic layout which is:
by
Idem for the CSS file included in the partial file head.njk at line 14 to be replaced by
https://www.canada.ca/etc/designs/canada/wet-boew/css/theme.min.cssFrom this project we are not going to create our own version of wet-boew or of GCWeb So instead of maintaining a dependencies, Soon wet-boew and gcweb are going to be released 2-3 times per months. I recommend to point to the latest version hosted in Canada.ca. We are not planning to do any breaking changes in wet-boew and gcweb from the web authors point of view.
That don't block us to extend the existing style, like it was already configured neither to submit a PR in wet-boew or GCWeb GitHub repository to fix an accessibility issue.
I will be interested to know why we need to have a custom CSS for this site. Is there missing a feature / a style in GCWeb? Also that information would be useful later for the GC Design System project.
Beta Was this translation helpful? Give feedback.
All reactions