-
Notifications
You must be signed in to change notification settings - Fork 68
Open
Description
Verify latest release
- I verified that the issue exists in the latest Hermione release
Hermione version
Last Hermione version that worked
Which area(s) of Hermione are affected? (leave empty if unsure)
No response
Link to the code that reproduces this issue or a replay of the bug
NDA
Reproduction steps
install testplane with typescript and try
await this.browser.assertView('..., '...', {
...
invisibleElements: ['...'],
});
Actual Behavior
After migrating from hermione@8 to tesplane faced some problem with typings:
Typescript shows, that invisibleElements is not defined on assertView
await this.browser.assertView('..., '...', {
invisibleElements: ['...'],
});But tesplane works line invisibleElements are used.
We create patch for typings:
diff --git a/build/src/config/types.d.ts b/build/src/config/types.d.ts
index........ ...
--- a/build/src/config/types.d.ts
+++ b/build/src/config/types.d.ts
@@ -13,6 +13,12 @@ export interface BuildDiffOptsConfig {
ignoreCaret: boolean;
}
export interface AssertViewOptsConfig {
+ /**
+ * DOM-node selectors which will be ignored (painted with a black rectangle) when comparing images.
+ *
+ * @defaultValue `[]`
+ */
+ invisibleElements: string | Array<string>;
/**
* DOM-node selectors which will be ignored (painted with a black rectangle) when comparing images.
*
- Is it really bug in typings ?
- can you fix this ❤️ ?
Expected Behavior
No typing error
Which Node.js version are you using?
20.11.0
Metadata
Metadata
Assignees
Labels
No labels