Skip to content

Configure ui-tests for lite deployment #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 38 commits into from
Feb 26, 2025
Merged

Configure ui-tests for lite deployment #489

merged 38 commits into from
Feb 26, 2025

Conversation

@arjxn-py
Copy link
Member

@arjxn-py arjxn-py commented Feb 24, 2025 •
edited
Loading

Description

Porting jupytercad/JupyterCAD#689

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--489.org.readthedocs.build/en/489/
💡 JupyterLite preview: https://jupytergis--489.org.readthedocs.build/en/489/lite

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2025

Binder 👈 Launch a Binder on branch arjxn-py/jupytergis/ui-tests-lite

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2025 •
edited
Loading

Integration tests report: appsharing.space

martinRenou
martinRenou reviewed Feb 24, 2025
View reviewed changes
@arjxn-py
Copy link
Member Author

arjxn-py commented Feb 25, 2025

Please update snapshots

@arjxn-py
Copy link
Member Author

arjxn-py commented Feb 25, 2025

Please update snapshots

@arjxn-py
Copy link
Member Author

arjxn-py commented Feb 25, 2025

Please update snapshots

@arjxn-py
Copy link
Member Author

arjxn-py commented Feb 25, 2025

Please update snapshots

@arjxn-py arjxn-py changed the title [WIP]: Configure ui-tests for lite deployment Configure ui-tests for lite deployment Feb 25, 2025
@arjxn-py arjxn-py marked this pull request as ready for review February 25, 2025 17:35
@arjxn-py arjxn-py closed this Feb 25, 2025
@arjxn-py arjxn-py reopened this Feb 25, 2025
@arjxn-py arjxn-py requested a review from martinRenou February 26, 2025 07:58
@arjxn-py
Copy link
Member Author

arjxn-py commented Feb 26, 2025

Please update snapshots

@martinRenou
Copy link
Member

martinRenou commented Feb 26, 2025

Triggering the CI after the bot update!

@martinRenou martinRenou reopened this Feb 26, 2025
@arjxn-py
Copy link
Member Author

arjxn-py commented Feb 26, 2025

i'm inspecting the lite-test results (downloading rn)

@arjxn-py
Copy link
Member Author

arjxn-py commented Feb 26, 2025

Please update snapshots again 🤕

@arjxn-py
Copy link
Member Author

arjxn-py commented Feb 26, 2025 •
edited
Loading

image
This was the diff

image

@arjxn-py
Copy link
Member Author

arjxn-py commented Feb 26, 2025

Oh, and update snapshots failed, since ui-tests passed. I'll re-run lite-integration tests

martinRenou
martinRenou requested changes Feb 26, 2025
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have one minor concern about duplication

@martinRenou martinRenou merged commit 0412ff3 into geojupyter:main Feb 26, 2025
25 checks passed
@arjxn-py arjxn-py mentioned this pull request Jul 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees

No one assigned

Labels

maintenance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arjxn-py @martinRenou