use big-brain to get url from CONVEX_DEPLOY_KEY (#34040)

preparation for canonical custom domains

instead of generating urls from deploy keys, use the `/url_for_key` endpoint when deploying with a CONVEX_DEPLOY_KEY to find the url. This allows us to switch from .convex.cloud to a custom domain in a future change.

With this change, the CLI should never try to calculate the url itself, and it shouldn't care what the url looks like. Therefore we should be able to change big-brain apis to return new urls, and the CLI should use them everywhere.

Now that we're using `/url_for_key` in more places, update its docstring. Note it's unusual as an endpoint because it doesn't check authorization with the normal ExtractIdentity, but as long as we validate the deploy key and only return the url, there should be no authz concerns.

GitOrigin-RevId: 453c4444c6285ad2192d25abe948e2a54d13db0c

Author: ldanilek

npm-packages/convex/src/cli/lib/api.ts

@@ -397,19 +397,16 @@ async function fetchDeploymentCredentialsWithinCurrentProjectInner(
         ctx,
         configuredAdminKey!,
       );
-      let url = await deriveUrlFromAdminKey(ctx, configuredAdminKey!);
-      // We cannot derive the deployment URL from the deploy key
-      // when running against local big brain, so use the name to get the URL.
-      if (process.env.CONVEX_PROVISION_HOST !== undefined) {
-        url = await bigBrainAPI({
-          ctx,
-          method: "POST",
-          url: "deployment/url_for_key",
-          data: {
-            deployKey: configuredAdminKey,
-          },
-        });
-      }
+      // We cannot derive the deployment URL from the deploy key, because it
+      // might be a custom domain. Ask big brain for the URL.
+      const url = await bigBrainAPI({
+        ctx,
+        method: "POST",
+        url: "deployment/url_for_key",
+        data: {
+          deployKey: configuredAdminKey,
+        },
+      });
       const deploymentType = deploymentTypeFromAdminKey(configuredAdminKey!);
       return {
         adminKey: configuredAdminKey,
@@ -617,11 +614,3 @@ async function fetchExistingDevDeploymentCredentialsOrCrash(
   }
   return credentialsAsDevCredentials(credentials);
 }
-
-// This returns the the url of the deployment from an admin key in the format
-//      "tall-forest-1234|1a2b35123541"
-//   or "prod:tall-forest-1234|1a2b35123541"
-async function deriveUrlFromAdminKey(ctx: Context, adminKey: string) {
-  const deploymentName = await deploymentNameFromAdminKeyOrCrash(ctx, adminKey);
-  return `https://${deploymentName}.convex.cloud`;
-}