Remove ability for clients to select partition_id (#39001)

GitOrigin-RevId: 34551c28ee8824bbe5aaabee1bacbccb665fa163

Author: nipunn1313

crates/backend_harness/src/provision.rs

@@ -18,7 +18,6 @@ use backoff::{
 };
 use big_brain_client::BigBrainClient;
 use big_brain_private_api_types::{
-    types::PartitionId,
     DeploymentAuthPreviewArgs,
     DeploymentAuthProdArgs,
     DeploymentAuthResponse,
@@ -284,14 +283,9 @@ async fn deployment_credentials(
                 .await
         },
         DeploymentSelector::Prod => {
-            let partition_id = env::var("PARTITION_ID")
-                .ok()
-                .map(|s| anyhow::Ok(PartitionId(s.parse::<u64>()?)))
-                .transpose()?;
             client
                 .prod_deployment_credentials(DeploymentAuthProdArgs {
                     deployment_name: configured_deployment_name,
-                    partition_id,
                 })
                 .await
         },
@@ -311,10 +305,7 @@ async fn preview_deploy_key(
         .get_project_and_team_for_deployment(deployment_name.clone())
         .await?;
     let prod_credentials = client
-        .prod_deployment_credentials(DeploymentAuthProdArgs {
-            deployment_name,
-            partition_id: None,
-        })
+        .prod_deployment_credentials(DeploymentAuthProdArgs { deployment_name })
         .await?;
 
     let admin_key_parts = prod_credentials.admin_key.split_once('|');
@@ -687,9 +678,6 @@ async fn provision_from_big_brain(
                     .arg("--configure=new")
                     .arg("--project")
                     .arg("load_generator");
-                if let Ok(partition_id) = env::var("PARTITION_ID") {
-                    cmd.arg("--partition-id").arg(partition_id);
-                }
                 logs.spawn_with_prefixed_logs(
                     "npx convex dev --configure=new".into(),
                     cmd.env("CONVEX_PROVISION_HOST", provision_host)
@@ -711,9 +699,6 @@ async fn provision_from_big_brain(
                     .arg("deploy")
                     .arg("--preview-create")
                     .arg(identifier);
-                if let Ok(partition_id) = env::var("PARTITION_ID") {
-                    cmd.arg("--partition-id").arg(partition_id);
-                }
                 logs.spawn_with_prefixed_logs(
                     format!("npx convex deploy --preview-create {identifier}"),
                     cmd.env("CONVEX_PROVISION_HOST", provision_host)
@@ -783,10 +768,6 @@ async fn deploy(
                     .arg("--yes")
                     .env("CONVEX_PROVISION_HOST", provision_host)
                     .env("CONVEX_OVERRIDE_ACCESS_TOKEN", access_token);
-                if let Ok(partition_id) = env::var("PARTITION_ID") {
-                    tracing::info!("Using partition_id: {partition_id}");
-                    cmd.arg("--partition-id").arg(partition_id);
-                }
                 cmd
             },
             // Only pass the ADMIN_KEY in directly with local backend to bypass dependency on

crates/big_brain_private_api_types/src/lib.rs

@@ -70,7 +70,6 @@ impl DeploymentAuthArgs {
 #[serde(deny_unknown_fields)]
 pub struct DeploymentAuthProdArgs {
     pub deployment_name: String,
-    pub partition_id: Option<PartitionId>,
 }
 
 #[derive(Deserialize, Serialize)]

npm-packages/convex/src/cli/configure.ts

@@ -110,7 +110,6 @@ export async function deploymentCredentialsOrConfigure(
   deploymentSelection: DeploymentSelection,
   chosenConfiguration: ChosenConfiguration,
   cmdOptions: ConfigureCmdOptions,
-  partitionId?: number | undefined,
 ): Promise<
   DeploymentCredentials & {
     deploymentFields: {
@@ -126,7 +125,6 @@ export async function deploymentCredentialsOrConfigure(
     deploymentSelection,
     chosenConfiguration,
     cmdOptions,
-    partitionId,
   );
 
   if (selectedDeployment.deploymentFields !== null) {
@@ -161,7 +159,6 @@ export async function _deploymentCredentialsOrConfigure(
   deploymentSelection: DeploymentSelection,
   chosenConfiguration: ChosenConfiguration,
   cmdOptions: ConfigureCmdOptions,
-  partitionId?: number | undefined,
 ): Promise<
   DeploymentCredentials & {
     deploymentFields: {
@@ -215,7 +212,6 @@ export async function _deploymentCredentialsOrConfigure(
         chosenConfiguration,
         {
           globallyForceCloud,
-          partitionId,
         },
         cmdOptions,
       );
@@ -232,7 +228,6 @@ export async function _deploymentCredentialsOrConfigure(
         targetProject: deploymentSelection.targetProject,
         cmdOptions,
         globallyForceCloud,
-        partitionId,
       });
     }
     case "anonymous": {
@@ -255,7 +250,6 @@ export async function _deploymentCredentialsOrConfigure(
           chosenConfiguration,
           {
             globallyForceCloud,
-            partitionId,
           },
           cmdOptions,
         );
@@ -311,7 +305,6 @@ export async function _deploymentCredentialsOrConfigure(
         chosenConfiguration,
         {
           globallyForceCloud,
-          partitionId,
         },
         cmdOptions,
       );
@@ -326,13 +319,11 @@ async function handleDeploymentWithinProject(
     targetProject,
     cmdOptions,
     globallyForceCloud,
-    partitionId,
   }: {
     chosenConfiguration: ChosenConfiguration;
     targetProject: ProjectSelection;
     cmdOptions: ConfigureCmdOptions;
     globallyForceCloud: boolean;
-    partitionId?: number | undefined;
   },
 ) {
   const hasAuth = ctx.bigBrainAuth() !== null;
@@ -353,7 +344,6 @@ async function handleDeploymentWithinProject(
       chosenConfiguration,
       {
         globallyForceCloud,
-        partitionId,
       },
       cmdOptions,
     );
@@ -368,7 +358,6 @@ async function handleDeploymentWithinProject(
       chosenConfiguration,
       {
         globallyForceCloud,
-        partitionId,
       },
       cmdOptions,
     );
@@ -410,7 +399,6 @@ async function handleChooseProject(
   chosenConfiguration: ChosenConfiguration,
   args: {
     globallyForceCloud: boolean;
-    partitionId?: number | undefined;
   },
   cmdOptions: ConfigureCmdOptions,
 ): Promise<
@@ -435,7 +423,6 @@ async function handleChooseProject(
     devDeployment: cmdOptions.devDeployment,
     local: args.globallyForceCloud ? false : cmdOptions.local,
     cloud: args.globallyForceCloud ? true : cmdOptions.cloud,
-    partitionId: args.partitionId,
   });
   // TODO complain about any non-default cmdOptions.localOptions here
   // because we're ignoring them if this isn't a local development.
@@ -454,7 +441,6 @@ async function handleChooseProject(
     teamSlug: project.teamSlug,
     projectSlug: project.projectSlug,
     deploymentOptions,
-    partitionId: args.partitionId,
   });
   return {
     url,
@@ -503,7 +489,6 @@ export async function selectProject(
     devDeployment?: "cloud" | "local" | undefined;
     local?: boolean | undefined;
     cloud?: boolean | undefined;
-    partitionId?: number;
     defaultProjectName?: string | undefined;
   },
 ): Promise<{
@@ -540,7 +525,6 @@ async function selectNewProject(
     devDeployment?: "cloud" | "local" | undefined;
     cloud?: boolean | undefined;
     local?: boolean | undefined;
-    partitionId?: number | undefined;
     defaultProjectName?: string | undefined;
   },
 ) {
@@ -578,7 +562,6 @@ async function selectNewProject(
     ({ projectSlug, teamSlug, projectsRemaining } = await createProject(ctx, {
       teamSlug: selectedTeam,
       projectName,
-      partitionId: config.partitionId,
       // We have to create some deployment initially for a project.
       deploymentTypeToProvision: devDeployment === "local" ? "prod" : "dev",
     }));
@@ -712,7 +695,6 @@ async function ensureDeploymentProvisioned(
     teamSlug: string;
     projectSlug: string;
     deploymentOptions: DeploymentOptions;
-    partitionId: number | undefined;
   },
 ): Promise<DeploymentDetails> {
   switch (options.deploymentOptions.kind) {
@@ -727,7 +709,6 @@ async function ensureDeploymentProvisioned(
             projectSlug: options.projectSlug,
           },
           options.deploymentOptions.kind,
-          options.partitionId,
         );
       return {
         ...credentials,

npm-packages/convex/src/cli/deploy.ts

@@ -174,7 +174,6 @@ async function deployToNewPreviewDeployment(
 
     debug?: boolean | undefined;
     debugBundlePath?: string | undefined;
-    partitionId?: string | undefined;
   },
 ) {
   const previewName = options.previewCreate ?? gitBranchFromEnvironment();
@@ -215,9 +214,6 @@ async function deployToNewPreviewDeployment(
     data: {
       projectSelection: deploymentSelection.projectSelection,
       identifier: previewName,
-      partitionId: options.partitionId
-        ? parseInt(options.partitionId)
-        : undefined,
     },
   });
 
@@ -285,7 +281,6 @@ async function deployToExistingDeployment(
     url?: string | undefined;
     writePushRequest?: string | undefined;
     liveComponentSources?: boolean | undefined;
-    partitionId?: string | undefined;
     envFile?: string | undefined;
   },
 ) {

npm-packages/convex/src/cli/dev.ts

@@ -224,9 +224,6 @@ Same format as .env.local or .env files, and overrides them.`,
       localOptions["forceUpgrade"] = cmdOptions.localForceUpgrade;
     }
 
-    const partitionId = cmdOptions.partitionId
-      ? parseInt(cmdOptions.partitionId)
-      : undefined;
     const configure =
       cmdOptions.configure === true ? "ask" : (cmdOptions.configure ?? null);
     const deploymentSelection = await getDeploymentSelection(ctx, cmdOptions);
@@ -239,7 +236,6 @@ Same format as .env.local or .env files, and overrides them.`,
         localOptions,
         selectionWithinProject,
       },
-      partitionId,
     );
 
     if (credentials.deploymentFields !== null) {