Skip to content

Commit 806585f

Browse files
Sujay JayakarConvex, Inc.
authored andcommitted
Also clean out definitions when disabling components (#30735)
GitOrigin-RevId: c4b3706fdd07c9f9d1bd38709e2567d88f1b0e01
1 parent a998ff4 commit 806585f

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

crates/model/src/components/config.rs

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -770,6 +770,18 @@ impl<'a, RT: Runtime> ComponentConfigModel<'a, RT> {
770770
tracing::warn!("Unmounting component: {:?}", &*component);
771771
self.unmount_component(&component).await?;
772772
}
773+
let existing_definitions = BootstrapComponentsModel::new(self.tx)
774+
.load_all_definitions()
775+
.await?;
776+
for (definition_path, definition) in existing_definitions {
777+
if definition_path.is_root() {
778+
continue;
779+
}
780+
ComponentDefinitionConfigModel::new(self.tx)
781+
.delete_component_definition(&definition)
782+
.await?;
783+
}
784+
773785
Ok(())
774786
}
775787
}

0 commit comments

Comments
 (0)