mark hmacSecret as required (#43418)

GitOrigin-RevId: dcf1290a299e73e984bc8e2ecbb956cf2e2c989a

Author: reeceyang

crates/local_backend/src/log_sinks.rs

@@ -106,7 +106,7 @@ pub async fn regenerate_webhook_secret(
     let config = WebhookConfig {
         url: existing_webhook_sink.url,
         format: existing_webhook_sink.format,
-        hmac_secret: Some(hmac_secret),
+        hmac_secret,
     };
     st.application
         .add_log_sink(SinkConfig::Webhook(config))
@@ -136,7 +136,7 @@ pub async fn add_webhook_sink(
 
     let hmac_secret = match existing_webhook_sink {
         Some(SinkConfig::Webhook(WebhookConfig {
-            hmac_secret: Some(existing_secret),
+            hmac_secret: existing_secret,
             ..
         })) => existing_secret,
         _ => generate_webhook_hmac_secret(st.application.runtime()),
@@ -152,7 +152,7 @@ pub async fn add_webhook_sink(
     let config = WebhookConfig {
         url,
         format: args.format,
-        hmac_secret: Some(hmac_secret),
+        hmac_secret,
     };
     st.application
         .add_log_sink(SinkConfig::Webhook(config))

crates/model/src/log_sinks/types/webhook.rs

@@ -15,7 +15,7 @@ pub struct WebhookConfig {
     )]
     pub url: reqwest::Url,
     pub format: WebhookFormat,
-    pub hmac_secret: Option<String>,
+    pub hmac_secret: String,
 }
 
 #[cfg_attr(any(test, feature = "testing"), derive(proptest_derive::Arbitrary))]
@@ -31,7 +31,7 @@ pub enum WebhookFormat {
 pub struct SerializedWebhookConfig {
     pub url: String,
     pub format: WebhookFormat,
-    pub hmac_secret: Option<String>,
+    pub hmac_secret: String,
 }
 
 impl From<WebhookConfig> for SerializedWebhookConfig {