Skip to content

Commit 08c19b7

Browse files
committed
http187 fixup
Signed-off-by: davidradl <[email protected]>
1 parent ba4b324 commit 08c19b7

File tree

3 files changed

+2
-2
lines changed

3 files changed

+2
-2
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -581,6 +581,7 @@ Notes:
581581
| connector | required | The Value should be set to _rest-lookup_ |
582582
| format | required | Flink's format name that should be used to decode REST response, Use `json` for a typical REST endpoint. |
583583
| url | required | The base URL that should be use for GET requests. For example _http://localhost:8080/client_ |
584+
| asyncPolling | optional | true/false - determines whether Async Polling should be used. Mechanism is based on Flink's Async I/O. |
584585
| gid.connector.http.logging.level | optional | Logging levels for HTTP content. Valid values are `MIN` (the default), `REQRESPONSE` and `MAX`. |
585586
| lookup-method | optional | GET/POST/PUT (and any other) - determines what REST method should be used for lookup REST query. If not specified, `GET` method will be used. |
586587
| lookup.cache | optional | Enum possible values: `NONE`, `PARTIAL`. The cache strategy for the lookup table. Currently supports `NONE` (no caching) and `PARTIAL` (caching entries on lookup operation in external API). |

src/main/java/com/getindata/connectors/http/internal/sink/httpclient/PerRequestSubmitter.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ public PerRequestSubmitter(
2828
HttpClient httpClient) {
2929

3030
super(properties, headersAndValues, httpClient);
31+
3132
}
3233

3334
@Override

src/main/java/com/getindata/connectors/http/internal/table/lookup/BodyBasedRequestFactory.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,6 @@ protected Builder setUpRequestMethod(LookupQueryInfo lookupQueryInfo) {
4949
builder
5050
.uri(constructUri(lookupQueryInfo))
5151
.method(methodName, BodyPublishers.ofString(body));
52-
// we do not view the lookup keys as sensitive; therefore the request body is
53-
// not obfuscated.
5452
HttpLogger.getHttpLogger(options.getProperties()).logRequestBody(body);
5553
return builder;
5654
}

0 commit comments

Comments
 (0)