increasing code coverage

Author: maciejmaciejko-gid

src/main/java/com/getindata/connectors/http/internal/retry/HttpClientWithRetry.java

@@ -6,7 +6,6 @@
 import io.github.resilience4j.retry.RetryConfig;
 import lombok.Builder;
 import lombok.Getter;
-import lombok.NonNull;
 import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
 
@@ -25,9 +24,9 @@ public class HttpClientWithRetry {
     private final HttpResponseChecker responseChecker;
 
     @Builder
-    HttpClientWithRetry(@NonNull HttpClient httpClient,
-                        @NonNull RetryConfig retryConfig,
-                        @NonNull HttpResponseChecker responseChecker) {
+    HttpClientWithRetry(HttpClient httpClient,
+                        RetryConfig retryConfig,
+                        HttpResponseChecker responseChecker) {
         this.httpClient = httpClient;
         this.responseChecker = responseChecker;
         this.retryConfig = RetryConfig.from(retryConfig)
@@ -65,6 +64,7 @@ private <T> HttpResponse<T> task(
         var validationFailedException = new HttpStatusCodeValidationFailedException(
                 "Incorrect response code: " + response.statusCode(), response);
         if (responseChecker.isTemporalError(response)) {
+            log.debug("Retrying... Received response with code {} for request {}", response.statusCode(), request);
             throw new RetryHttpRequestException(validationFailedException);
         }
         throw validationFailedException;

src/main/java/com/getindata/connectors/http/internal/retry/RetryConfigProvider.java

@@ -31,14 +31,12 @@ private RetryConfig create() {
 
     private RetryConfig.Builder<?> createBuilder() {
         var retryStrategy = getRetryStrategy();
-        switch (retryStrategy) {
-            case FIXED_DELAY:
-                return configureFixedDelay();
-            case EXPONENTIAL_DELAY:
-                return configureExponentialDelay();
-            default:
-                throw new IllegalStateException("Unsupported retry strategy: " + retryStrategy);
+        if (retryStrategy == RetryStrategyType.FIXED_DELAY) {
+            return configureFixedDelay();
+        } else if (retryStrategy == RetryStrategyType.EXPONENTIAL_DELAY) {
+            return configureExponentialDelay();
         }
+        throw new IllegalArgumentException("Unsupported retry strategy: " + retryStrategy);
     }
 
     private RetryStrategyType getRetryStrategy() {

src/test/java/com/getindata/connectors/http/internal/retry/RetryConfigProviderTest.java

@@ -1,17 +1,19 @@
 package com.getindata.connectors.http.internal.retry;
 
 import org.apache.flink.configuration.Configuration;
-import org.apache.flink.util.ConfigurationException;
 import org.junit.jupiter.api.Test;
 
 import java.util.stream.IntStream;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.mockStatic;
 
 class RetryConfigProviderTest {
 
     @Test
-    void verifyFixedDelayRetryConfig() throws ConfigurationException {
+    void verifyFixedDelayRetryConfig() {
         var config = new Configuration();
         config.setString("gid.connector.http.source.lookup.retry-strategy.type", "fixed-delay");
         config.setString("gid.connector.http.source.lookup.retry-strategy.fixed-delay.delay", "10s");
@@ -26,7 +28,7 @@ void verifyFixedDelayRetryConfig() throws ConfigurationException {
     }
 
     @Test
-    void verifyExponentialDelayConfig() throws ConfigurationException {
+    void verifyExponentialDelayConfig() {
         var config = new Configuration();
         config.setString("gid.connector.http.source.lookup.retry-strategy.type", "exponential-delay");
         config.setString("gid.connector.http.source.lookup.retry-strategy.exponential-delay.initial-backoff", "15ms");
@@ -45,4 +47,18 @@ void verifyExponentialDelayConfig() throws ConfigurationException {
         assertEquals(120, intervalFunction.apply(5));
         assertEquals(120, intervalFunction.apply(6));
     }
+
+    @Test
+    void failWhenStrategyIsUnsupported() {
+        var config = new Configuration();
+        config.setString("gid.connector.http.source.lookup.retry-strategy.type", "dummy");
+
+        try (var mockedStatic = mockStatic(RetryStrategyType.class)) {
+            var dummyStrategy = mock(RetryStrategyType.class);
+            mockedStatic.when(() -> RetryStrategyType.fromCode("dummy")).thenReturn(dummyStrategy);
+
+            assertThrows(IllegalArgumentException.class,
+                () -> RetryConfigProvider.create(config));
+        }
+    }
 }