ref: Fix clippy (#1411)

jjbayer · web-flow · commit 0d79cf44913c · 2022-08-12T10:28:26.000+02:00
- Automatically fix linter issues introduced by clippy 0.1.63.
- Disable lint clippy::derive_partial_eq_without_eq.
diff --git a/relay-auth/src/lib.rs b/relay-auth/src/lib.rs
@@ -2,6 +2,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 use std::fmt;
 use std::str::FromStr;
 
diff --git a/relay-aws-extension/src/lib.rs b/relay-aws-extension/src/lib.rs
@@ -26,6 +26,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 mod aws_extension;
 pub use aws_extension::*;
diff --git a/relay-cabi/src/lib.rs b/relay-cabi/src/lib.rs
@@ -95,6 +95,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 mod auth;
 mod constants;
diff --git a/relay-cabi/src/processing.rs b/relay-cabi/src/processing.rs
@@ -1,6 +1,7 @@
 // TODO: Fix casts between RelayGeoIpLookup and GeoIpLookup
 #![allow(clippy::cast_ptr_alignment)]
 #![deny(unused_must_use)]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 use std::cmp::Ordering;
 use std::ffi::CStr;
diff --git a/relay-common/src/lib.rs b/relay-common/src/lib.rs
@@ -4,6 +4,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 mod macros;
 
diff --git a/relay-config/src/lib.rs b/relay-config/src/lib.rs
@@ -4,6 +4,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 mod byte_size;
 mod config;
diff --git a/relay-ffi-macros/src/lib.rs b/relay-ffi-macros/src/lib.rs
@@ -7,6 +7,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 use proc_macro::TokenStream;
 use quote::ToTokens;
diff --git a/relay-ffi/src/lib.rs b/relay-ffi/src/lib.rs
@@ -104,6 +104,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 use std::cell::RefCell;
 use std::error::Error;
diff --git a/relay-filter/src/lib.rs b/relay-filter/src/lib.rs
@@ -11,6 +11,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 use std::net::IpAddr;
 
diff --git a/relay-general/derive/src/lib.rs b/relay-general/derive/src/lib.rs
@@ -5,6 +5,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 mod empty;
 mod jsonschema;
diff --git a/relay-general/src/lib.rs b/relay-general/src/lib.rs
@@ -1,6 +1,7 @@
 // Clippy throws errors in situations where a closure is clearly the better way. An example is
 // `Annotated::as_str`, which can't be used directly because it's part of two impl blocks.
 #![allow(clippy::redundant_closure)]
+#![allow(clippy::derive_partial_eq_without_eq)]
 #![deny(unused_must_use)]
 #![doc(
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
diff --git a/relay-general/src/store/normalize.rs b/relay-general/src/store/normalize.rs
@@ -434,7 +434,7 @@ fn normalize_security_report(
         if !headers.contains("User-Agent") {
             headers.insert(
                 HeaderName::new("User-Agent"),
-                Annotated::new(HeaderValue::new(&(*client))),
+                Annotated::new(HeaderValue::new(client)),
             );
         }
     }
diff --git a/relay-log/src/lib.rs b/relay-log/src/lib.rs
@@ -108,6 +108,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 #[cfg(feature = "sentry")]
 mod sentry_failure;
diff --git a/relay-metrics/src/lib.rs b/relay-metrics/src/lib.rs
@@ -96,6 +96,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 mod aggregation;
 mod protocol;
diff --git a/relay-quotas/src/lib.rs b/relay-quotas/src/lib.rs
@@ -5,6 +5,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 /// The default timeout to apply when a scope is fully rejected. This
 /// typically happens for disabled keys, projects, or organizations.
diff --git a/relay-quotas/src/redis.rs b/relay-quotas/src/redis.rs
@@ -226,7 +226,7 @@ impl RedisRateLimiter {
         for (quota, is_rejected) in tracked_quotas.iter().zip(rejections) {
             if is_rejected {
                 let retry_after = self.retry_after((quota.expiry() - timestamp).as_secs());
-                rate_limits.add(RateLimit::from_quota(&*quota, &*item_scoping, retry_after));
+                rate_limits.add(RateLimit::from_quota(quota, &*item_scoping, retry_after));
             }
         }
 
diff --git a/relay-redis/src/lib.rs b/relay-redis/src/lib.rs
@@ -7,6 +7,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 mod config;
 pub use self::config::*;
diff --git a/relay-sampling/src/lib.rs b/relay-sampling/src/lib.rs
@@ -3,6 +3,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 use std::borrow::Cow;
 use std::collections::{BTreeMap, HashMap};
diff --git a/relay-server/src/endpoints/project_configs.rs b/relay-server/src/endpoints/project_configs.rs
@@ -45,7 +45,7 @@ impl<S> FromRequest<S> for VersionQuery {
     type Result = Self;
 
     fn from_request(req: &actix_web::HttpRequest<S>, _: &Self::Config) -> Self::Result {
-        Self::from_request(&*req)
+        Self::from_request(req)
     }
 }
 
diff --git a/relay-server/src/lib.rs b/relay-server/src/lib.rs
@@ -251,6 +251,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 mod actors;
 mod body;
diff --git a/relay-server/src/utils/multipart.rs b/relay-server/src/utils/multipart.rs
@@ -280,6 +280,7 @@ pub struct MultipartItems {
     remaining_size: usize,
     // Collect all form data in here.
     form_data: FormDataWriter,
+    #[allow(clippy::type_complexity)]
     infer_type: Box<dyn Fn(Option<&str>) -> AttachmentType>,
 }
 
diff --git a/relay-statsd/src/lib.rs b/relay-statsd/src/lib.rs
@@ -230,7 +230,7 @@ where
 {
     CURRENT_CLIENT.with(|client| {
         if let Some(client) = client {
-            f(&*client)
+            f(client)
         } else {
             R::default()
         }
diff --git a/relay-system/src/lib.rs b/relay-system/src/lib.rs
@@ -12,6 +12,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 pub mod compat;
 mod controller;
diff --git a/relay-test/src/lib.rs b/relay-test/src/lib.rs
@@ -25,6 +25,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 use std::{
     cell::RefCell,
diff --git a/relay/src/main.rs b/relay/src/main.rs
@@ -89,6 +89,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 mod cli;
 mod cliapp;
