clean up code after checking rate limiting and metric logic

Author: tobias-wilfert

relay-server/src/processing/client_reports/mod.rs

@@ -92,11 +92,7 @@ impl processing::Processor for ClientReportsProcessor {
             .enforce_quotas(&mut client_reports, ctx)
             .await?;
 
-        // FIXME: Not sure if we want to emit some metrics here still
-        Ok(Output {
-            main: None,
-            metrics: None,
-        })
+        Ok(Output::empty())
     }
 }
 
@@ -114,7 +110,6 @@ pub struct SerializedClientReport {
 
 impl Counted for SerializedClientReport {
     fn quantities(&self) -> Quantities {
-        // TODO: Check the envelope rete_limiter
         smallvec::smallvec![]
     }
 }

relay-server/src/processing/mod.rs

@@ -156,6 +156,14 @@ impl<T> Output<T> {
         }
     }
 
+    /// Creates an new output with neither main nor metrics.
+    pub fn empty() -> Self {
+        Self {
+            main: None,
+            metrics: None,
+        }
+    }
+
     /// Maps an `Output<T>` to `Output<S>` by applying a function to [`Self::main`].
     pub fn map<F, S>(self, f: F) -> Output<S>
     where