Skip to content

Commit d7c5698

Browse files
authored
instr(kafka): Log message type on send error (#1477)
From our statsd metrics it looks like it's not metrics that causes kafka messages that are too large. Let's verify this with a sentry error tagged by message type.
1 parent 1a64b6b commit d7c5698

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

relay-server/src/actors/store.rs

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -178,9 +178,13 @@ impl Producer {
178178
};
179179
let record = BaseRecord::to(topic_name).key(&key).payload(&serialized);
180180

181-
producer
182-
.send(record)
183-
.map_err(|(kafka_error, _message)| StoreError::SendFailed(kafka_error))
181+
producer.send(record).map_err(|(kafka_error, _message)| {
182+
relay_log::with_scope(
183+
|scope| scope.set_tag("variant", message.variant()),
184+
|| relay_log::error!("error sending kafka message: {}", kafka_error),
185+
);
186+
StoreError::SendFailed(kafka_error)
187+
})
184188
}
185189
}
186190

0 commit comments

Comments
 (0)