Skip to content

Commit 2f3d023

Browse files
authored
fix(ci): Re-enable skipped tests (#5104)
### Description We had to resort to skipping two tests in https://github.com/getsentry/sentry-python/pull/5088/files since they were blocking the release. Re-enabling them here. It looks like the worst of the flakiness comes with newer coverage (>=7.11.1). Pinning it here. #### Issues Closes #5101 Closes https://linear.app/getsentry/issue/PY-1974/fix-skipped-tests #### Reminders - Please add tests to validate your changes, and lint your code using `tox -e linters`. - Add GH Issue ID _&_ Linear ID (if applicable) - PR title should use [conventional commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type) style (`feat:`, `fix:`, `ref:`, `meta:`) - For external contributors: [CONTRIBUTING.md](https://github.com/getsentry/sentry-python/blob/master/CONTRIBUTING.md), [Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord community](https://discord.gg/Ww9hbqr)
1 parent 0aebb18 commit 2f3d023

File tree

4 files changed

+4
-2
lines changed

4 files changed

+4
-2
lines changed

scripts/populate_tox/tox.jinja

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,8 @@ deps =
8181
# for justification of the upper bound on pytest
8282
{py3.6,py3.7}-common: pytest<7.0.0
8383
{py3.8,py3.9,py3.10,py3.11,py3.12,py3.13,py3.14,py3.14t}-common: pytest
84+
# coverage 7.11.1-7.11.3 makes some of our tests flake
85+
{py3.14,py3.14t}-common: coverage==7.11.0
8486
8587
# === Gevent ===
8688
{py3.6,py3.7,py3.8,py3.9,py3.10,py3.11}-gevent: gevent>=22.10.0, <22.11.0

tests/profiler/test_transaction_profiler.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,6 @@ def test_minimum_unique_samples_required(
266266

267267

268268
@pytest.mark.forked
269-
@pytest.mark.skipif(sys.version_info >= (3, 14), reason="Test flakes blocking release.")
270269
def test_profile_captured(
271270
sentry_init,
272271
capture_envelopes,

tests/tracing/test_decorator.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ async def test_trace_decorator_async():
7070

7171

7272
@pytest.mark.asyncio
73-
@pytest.mark.skipif(sys.version_info >= (3, 14), reason="Test flakes blocking release.")
7473
async def test_trace_decorator_async_no_trx():
7574
with patch_start_tracing_child(fake_transaction_is_none=True):
7675
with mock.patch.object(logger, "debug", mock.Mock()) as fake_debug:

tox.ini

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -318,6 +318,8 @@ deps =
318318
# for justification of the upper bound on pytest
319319
{py3.6,py3.7}-common: pytest<7.0.0
320320
{py3.8,py3.9,py3.10,py3.11,py3.12,py3.13,py3.14,py3.14t}-common: pytest
321+
# coverage 7.11.1-7.11.3 makes some of our tests flake
322+
{py3.14,py3.14t}-common: coverage==7.11.0
321323

322324
# === Gevent ===
323325
{py3.6,py3.7,py3.8,py3.9,py3.10,py3.11}-gevent: gevent>=22.10.0, <22.11.0

0 commit comments

Comments
 (0)