chore(local dev): Allow for custom GRPC port to be specified #492
Conversation
NicoHinderling
force-pushed
the
allow-for-local-dev-grpc-port-value
branch
2 times, most recently
from
56c8921 to
c37ec26
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #492 +/- ##
=======================================
Coverage 88.55% 88.55%
=======================================
Files 20 20
Lines 5559 5559
=======================================
Hits 4923 4923
Misses 636 636 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
NicoHinderling
force-pushed
the
allow-for-local-dev-grpc-port-value
branch
from
c37ec26 to
b1bb914
Compare
| environment: | ||
| TASKBROKER_KAFKA_CLUSTER: "kafka-kafka-1:9093" | ||
| TASKBROKER_CREATE_MISSING_TOPICS: "true" | ||
| TASKBROKER_GRPC_PORT: "50055" |
There was a problem hiding this comment.
the only problem is getting the port to be set to 50055 for local development when running taskbroker standalone. Putting an EXPORT TASKBROKER_GRPC_PORT=50055 in either .envrc or a new .env file did not work
I think the current approach should work for the docker container served from devservices, but I think this needs to still work for local taskbroker running side by side without requiring manual intervention from the dev
not sure the best way to accomplish that
There was a problem hiding this comment.
Changing the default port for locally run taskbroker would require a config file, or environment vars. We might want to try making all of these changes locally and seeing how colima handles the new port mapping. I suspect that ssh process we saw is how colima implements port forwarding and that getting the connections working can be attributed to running taskbroker outside of colima at the time.
| RUN apt-get update && apt-get upgrade -y && apt-get install -y libssl-dev libsqlite3-dev libsqlite3-0 openssl ca-certificates | ||
|
|
||
| EXPOSE 50051 | ||
| EXPOSE 50055 |
There was a problem hiding this comment.
expose both since IIRC the docker image is used for both cloudbuild (prod) and GHCR (devservices aka local)
I and some other coworkers had an issue where colima was using port 50051, which is the port that taskbroker also wants to use. Changing the port that taskbroker uses caused tasks to start flowing again
This is an attempt to use port 50055 solely in the devservices/local development environment
corresponding sentry PR: getsentry/sentry#100231