Skip to content

Commit 7caba4a

Browse files
committed
release/msi: strip 'v' from versions
Updates #48
1 parent 8a7a7c2 commit 7caba4a

File tree

2 files changed

+13
-19
lines changed

2 files changed

+13
-19
lines changed

.github/workflows/release.yml

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -64,17 +64,12 @@ jobs:
6464
run: go mod download
6565
env:
6666
GO111MODULE: on
67-
- name: Build executable
68-
run: |-
69-
release\build.ps1 `
70-
-version ($Env:GITHUB_REF).trimstart('refs/tags/') `
71-
-out release\msi\gg.exe
72-
env:
73-
GO111MODULE: on
7467
- name: Package release
75-
run: .\release.ps1 -version ($Env:GITHUB_REF).trimstart('refs/tags/')
68+
run: .\release.ps1 -version ($Env:GITHUB_REF).trimstart('refs/tags/v')
7669
working-directory: .\release\msi
7770
id: package
71+
env:
72+
GO111MODULE: on
7873
- name: Upload binary
7974
uses: actions/upload-release-asset@v1
8075
env:

release/msi/release.ps1

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -14,29 +14,28 @@
1414
#
1515
# SPDX-License-Identifier: Apache-2.0
1616

17-
param($version='')
17+
param($version='dev')
1818

1919
If ( ! ( Test-Path Env:wix ) ) {
2020
Write-Error 'WiX not installed; cannot find %wix%.'
2121
exit 1
2222
}
2323

24-
$filename="gg"
25-
If ( $version -ne '' ) {
26-
$filename+="_${version}"
27-
}
28-
$filename+=".msi"
29-
24+
$filename="gg_${version}_amd64.msi"
3025
$wixVersion="0.0.0"
31-
$wixVersionMatch=[regex]::Match($version, '^v([0-9]+\.[0-9]+\.[0-9]+)')
26+
$wixVersionMatch=[regex]::Match($version, '^([0-9]+\.[0-9]+\.[0-9]+)')
3227
If ( $wixVersionMatch.success ) {
3328
$wixVersion=$wixVersionMatch.captures.groups[1].value
34-
} Elseif ( $version -ne '' ) {
29+
} Elseif ( $version -ne 'dev' ) {
3530
Write-Error "Invalid version $version"
3631
exit 1
3732
}
3833

39-
& "${env:wix}bin\\candle.exe" `
34+
..\build.ps1 `
35+
-version $version `
36+
-out gg.exe
37+
38+
& "${env:wix}bin\candle.exe" `
4039
-nologo `
4140
-arch x64 `
4241
"-dGgVersion=$version" `
@@ -45,7 +44,7 @@ If ( $wixVersionMatch.success ) {
4544
If ( $LastExitCode -ne 0 ) {
4645
exit $LastExitCode
4746
}
48-
& "${env:wix}bin\\light.exe" `
47+
& "${env:wix}bin\light.exe" `
4948
-nologo `
5049
-dcl:high `
5150
-ext WixUIExtension `

0 commit comments

Comments
 (0)