Pasting more than 2 rows inserts blank rows

[pcadec]

Describe the bug

Dear Ghislain,

When pasting 3 or more rows, then blank rows are inserted every other row.
Errors occurs when data is copied from Excel, but also when copied from Slickgrid itself.

I fixed it locally in the file /packages/common/src/extensions/slickCellExternalCopyManager.ts

Inside decodeTabularData(grid, clipText)
I replaced
const clipRows = clipText.replace('\r\n', '\n').split(/\n\f\r/);
By
const clipRows = clipText.replaceAll('\r\n', '\n').split(/\n\f\r/);

Thanks for your consideration on the topic

Reproduction

Bug occured with Chrome version 139.0.7258.155 but NOT in Firefox 142.0.1

It can be reproducted directly on this demo page :
https://ghiscoding.github.io/angular-slickgrid-demos/#/example03

When reproducing on the demo page, just click "ok" to all "This is a required field". These alert are thrown because of blank lines inserted, which can be seen when all the alerts are closed.

Which Framework are you using?

Angular

Environment Info

| Executable          | Version |
| ------------------- | ------- |
| (framework used)    | ANGULAR |
| Slickgrid-Universal | 9.8.0   |
| TypeScript          | 5.5.4   |
| Browser(s)          | CHROME 139|
| System OS           | WINDOWS 11 |

Validations

• Follow our Code of Conduct
• Read the Wikis.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion.
• The provided reproduction is a minimal reproducible example of the bug.

[ghiscoding]

I'm not a big user of the Excel Copy Buffer but @zewa666 is one of those users. The proposed patch seems good enough, I would be open to get a Pull Request contribution for this (which you probably do directly in GitHub website since that seems easy enough with 1 line to update).

On a side note, there's another big feature coming in the near future, created by Ben on the original 6pac/SlickGrid, to bring an HybridSelectionModel which will bring support to do both Row Selections and Cell Selections in the same grid (also adds a drag-fill feature like Excel). I'm not sure how long it will take to release this upcoming feature and it might delay the push of another release. See this SlickGrid PR for more details.

[zewa666]

uff there are a couple more issues there. will have another Sprint in a few weeks where we'll get our e2e test suite up and running and checking through various paste scenarios. than I'd also contribute the fixes back. the issue with the Excel copy buffer is the amount of variation. e.g you shouldnt replace newlines if these are within quotes, as that is an intended newline inside a cell.

[zewa666]

Sorry for not coming back to @pcadec on this one. Had some super stressful weeks with school starting for one of my kids and the other one into kindergarden plus lots of work :)

Anyways I could reproduce your issue on Example3 as you mentioned. I've checked it against our companies app, and there the issue is already covered with the couple changes we have applied to copy/paste behavior.
https://github.com/user-attachments/assets/1e8b4d87-e93d-4583-bdd8-352cf5d9df2e

Issue is, I don't really have a clue any longer which of these are making sure it works 🤣

I'll have to go through them and open up a new PR. stay tuned

[koimeria]

Thanks @zewa666 for your message !

I'll stay tuned